Skip to content

Update license expiry calculation to ensure integer return type, now I get a float with -20.91572169669 #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
groax wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update license expiry calculation to ensure integer return type, now I get a float with -20.91572169669 #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion resources/views/customer/licenses/index.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ class="mt-3 inline-flex w-full justify-center rounded-md bg-white px-3 py-2 text
@foreach($licenses as $license)
@php
$isLegacyLicense = $license->isLegacy();
$daysUntilExpiry = $license->expires_at ? $license->expires_at->diffInDays(now()) : null;
$daysUntilExpiry = $license->expires_at ? (int) now()->diffInDays($license->expires_at, false) : null;
$needsRenewal = $isLegacyLicense && $daysUntilExpiry !== null && !$license->expires_at->isPast();
@endphp
<li class="{{ $needsRenewal ? 'bg-blue-50 dark:bg-blue-900/20' : '' }}">
Expand Down
2 changes: 1 addition & 1 deletion resources/views/customer/licenses/list.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
@foreach($licenses as $license)
@php
$isLegacyLicense = $license->isLegacy();
$daysUntilExpiry = $license->expires_at ? $license->expires_at->diffInDays(now()) : null;
$daysUntilExpiry = $license->expires_at ? (int) now()->diffInDays($license->expires_at, false) : null;
$needsRenewal = $isLegacyLicense && $daysUntilExpiry !== null && !$license->expires_at->isPast();
@endphp
<li class="{{ $needsRenewal ? 'bg-blue-50 dark:bg-blue-900/20' : '' }}">
Expand Down
2 changes: 1 addition & 1 deletion resources/views/customer/licenses/show.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ class="ml-2 inline-flex items-center px-2.5 py-1.5 border border-gray-300 dark:b

@php
$isLegacyLicense = $license->isLegacy();
$daysUntilExpiry = $license->expires_at ? $license->expires_at->diffInDays(now()) : null;
$daysUntilExpiry = $license->expires_at ? (int) now()->diffInDays($license->expires_at, false) : null;
$needsRenewal = $isLegacyLicense && $daysUntilExpiry !== null;
@endphp

Expand Down
2 changes: 1 addition & 1 deletion resources/views/livewire/customer/licenses.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
@foreach($this->licenses as $license)
@php
$isLegacyLicense = $license->isLegacy();
$daysUntilExpiry = $license->expires_at ? $license->expires_at->diffInDays(now()) : null;
$daysUntilExpiry = $license->expires_at ? (int) now()->diffInDays($license->expires_at, false) : null;
$needsRenewal = $isLegacyLicense && $daysUntilExpiry !== null && !$license->expires_at->isPast();

$status = match(true) {
Expand Down
2 changes: 1 addition & 1 deletion resources/views/livewire/customer/licenses/show.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
{{-- Renewal CTA --}}
@php
$isLegacyLicense = $license->isLegacy();
$daysUntilExpiry = $license->expires_at ? $license->expires_at->diffInDays(now()) : null;
$daysUntilExpiry = $license->expires_at ? (int) now()->diffInDays($license->expires_at, false) : null;
$needsRenewal = $isLegacyLicense && $daysUntilExpiry !== null;
@endphp

Expand Down