fix: correct greeting conversation state logic bugs#2298
Open
wtoqxy0000 wants to merge 3 commits intoOpenMind:mainfrom
Open
fix: correct greeting conversation state logic bugs#2298wtoqxy0000 wants to merge 3 commits intoOpenMind:mainfrom
wtoqxy0000 wants to merge 3 commits intoOpenMind:mainfrom
Conversation
1. Remove duplicate assignment in reset_state() that always overwrites the initial_state parameter with CONVERSING, causing callers like approaching_person to never enter the ENGAGING state. 2. Compare against ConversationState.FINISHED.value (string) instead of ConversationState.FINISHED (enum) in connect() of both elevenlabs and kokoro connectors, matching the dict returned by process_conversation() which uses .value. The tick() method in the same files already uses .value correctly.
github-actions
bot
added
robotics
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reset_state()ingreeting_conversation_state_provider.pyignores itsinitial_stateparameter — line 585 unconditionally overwritesself.current_statewithCONVERSING, making the parameter useless. The callerapproaching_person.pypassesENGAGINGbut it never takes effect.connect()in bothgreeting_conversation_elevenlabs.pyandgreeting_conversation_kokoro.pycomparesresponse.get("current_state")againstConversationState.FINISHED(enum object), butprocess_conversation()returnsself.current_state.value(string"finished"). The comparison is alwaysFalse, so the context update is never sent fromconnect(). Thetick()method in the same files already correctly uses.value.Changes
src/providers/greeting_conversation_state_provider.py:585self.current_state = ConversationState.CONVERSINGsrc/actions/.../greeting_conversation_elevenlabs.py:135ConversationState.FINISHED→ConversationState.FINISHED.valuesrc/actions/.../greeting_conversation_kokoro.py:149ConversationState.FINISHED→ConversationState.FINISHED.valueTest plan