Skip to content

fix: correct greeting conversation state logic bugs #2298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wtoqxy0000 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: correct greeting conversation state logic bugs #2298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9dc44bf
fix: correct greeting conversation state logic bugs
wtoqxy0000 Feb 16, 2026
b9aa48c
Merge branch 'main' into fix/greeting-conversation-state-bugs
0xbyt4 Feb 16, 2026
b6344a0
Merge branch 'main' into fix/greeting-conversation-state-bugs
0xbyt4 Feb 16, 2026
f106cf7
fix: add ENGAGING state handler to prevent state machine deadlock
wtoqxy0000 Feb 17, 2026
809800b
Merge branch 'main' into fix/greeting-conversation-state-bugs
0xbyt4 Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/actions/greeting_conversation/connector/greeting_conversation_elevenlabs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ async def connect(self, output_interface: GreetingConversationInput) -> None:
response = self.greeting_state_provider.process_conversation(llm_output)
logging.info(f"Greeting Conversation Response: {response}")

if response.get("current_state") == ConversationState.FINISHED:
if response.get("current_state") == ConversationState.FINISHED.value:
logging.info("Greeting conversation has finished.")
self.context_provider.update_context(
{"greeting_conversation_finished": True}
Expand Down
2 changes: 1 addition & 1 deletion src/actions/greeting_conversation/connector/greeting_conversation_kokoro.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ async def connect(self, output_interface: GreetingConversationInput) -> None:
response = self.greeting_state_provider.process_conversation(llm_output)
logging.info(f"Greeting Conversation Response: {response}")

if response.get("current_state") == ConversationState.FINISHED:
if response.get("current_state") == ConversationState.FINISHED.value:
logging.info("Greeting conversation has finished.")
self.context_provider.update_context(
{"greeting_conversation_finished": True}
Expand Down
5 changes: 4 additions & 1 deletion src/providers/greeting_conversation_state_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,10 @@ def _determine_next_state(
llm_conversation_state = confidence_result["factors"].conversation_state
time_in_state = time.time() - self.state_entry_time

# From ENGAGING to CONVERSING
if self.current_state == ConversationState.ENGAGING:
return ConversationState.CONVERSING

# From CONVERSING to CONCLUDING
if self.current_state == ConversationState.CONVERSING:
# LLM thinks we should conclude with high confidence
Expand Down Expand Up @@ -582,4 +586,3 @@ def reset_state(
self.turn_count = 0
self.last_user_utterance = ""
self.confidence_history = []
self.current_state = ConversationState.CONVERSING
2 changes: 1 addition & 1 deletion tests/actions/greeting_conversation/connector/test_greeting_conversation_elevenlabs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ async def test_connect_finished_updates_context(self, connector, mock_providers)
speech_clarity=0.9,
)
mock_providers["state"].process_conversation.return_value = {
"current_state": ConversationState.FINISHED
"current_state": ConversationState.FINISHED.value
}
await connector.connect(finished_input)
mock_providers["ctx"].update_context.assert_called_once_with(
Expand Down
2 changes: 1 addition & 1 deletion tests/actions/greeting_conversation/connector/test_greeting_conversation_kokoro.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ async def test_connect_finished_updates_context(self, connector, mock_providers)
speech_clarity=0.9,
)
mock_providers["state"].process_conversation.return_value = {
"current_state": ConversationState.FINISHED
"current_state": ConversationState.FINISHED.value
}
await connector.connect(finished_input)
mock_providers["ctx"].update_context.assert_called_once_with(
Expand Down
2 changes: 1 addition & 1 deletion tests/providers/test_greeting_conversation_state_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ def test_reset_state(self, state_machine):

state_machine.reset_state(ConversationState.IDLE)

assert state_machine.current_state == ConversationState.CONVERSING
assert state_machine.current_state == ConversationState.IDLE
assert state_machine.turn_count == 0
assert state_machine.last_user_utterance == ""
assert state_machine.confidence_history == []
Expand Down
Loading