Exit with error when QuiverQuant fetch returns no data#7
Merged
AlexCatarino merged 1 commit intoMay 12, 2026
Merged
Conversation
Treat an empty per-ticker accumulator at Flush time as a connection failure: log an error and return false so Program.Main exits with code 1 instead of producing a silent success when the API is unreachable. Applies to CNBC and InsiderTrading downloaders, whose multi-date loops previously swallowed per-date failures. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flush()time as a hard failure (logs an error and returns false).Program.Mainto propagate theFlush()result so the process exits with code 1 instead of silently succeeding when the API is unreachable.Test plan
Flush(): No data accumulatederror.