Skip to content

Exit with error when QuiverQuant fetch returns no data #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexCatarino merged 1 commit into from
May 12, 2026
Merged

Exit with error when QuiverQuant fetch returns no data #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions DataProcessing/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,10 @@ public static void Main()
$"{VendorName} {QuiverCNBCDataDownloader.VendorDataName} data for date: {date:yyyy-MM-dd}");
}
}
instance.Flush();
if (!instance.Flush())
{
return false;
}
instance.ProcessUniverse();
return true;
});
Expand Down Expand Up @@ -138,7 +141,10 @@ public static void Main()
$"{VendorName} {QuiverInsiderTradingDataDownloader.VendorDataName} data for date: {date:yyyy-MM-dd}");
}
}
instance.Flush();
if (!instance.Flush())
{
return false;
}
instance.ProcessUniverse();
return true;
});
Expand Down
6 changes: 6 additions & 0 deletions DataProcessing/QuiverCNBCDataDownloader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,12 @@ public bool Run(DateTime processDate)
/// <returns>True on success</returns>
public bool Flush()
{
if (_cnbcByTicker.Count == 0)
{
Log.Error($"QuiverCNBCDataDownloader.Flush(): No data accumulated; treating run as a failure (likely unable to reach QuiverQuant).");
return false;
}

try
{
foreach (var kvp in _cnbcByTicker)
Expand Down
6 changes: 6 additions & 0 deletions DataProcessing/QuiverInsiderTradingDataDownloader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,12 @@ public bool Run(DateTime processDate)
/// <returns>True on success</returns>
public bool Flush()
{
if (_insiderTradingByTicker.Count == 0)
{
Log.Error($"QuiverInsiderTradingDataDownloader.Flush(): No data accumulated; treating run as a failure (likely unable to reach QuiverQuant).");
return false;
}

var failed = 0;
foreach (var kvp in _insiderTradingByTicker)
{
Expand Down
Loading