Migrate MemcacheSocket implementation to Rust#80
Merged
Conversation
Member
Author
5d1d82c to
0a3c9d8
Compare
04a0c2a to
abc3e7c
Compare
0a3c9d8 to
55bdd4c
Compare
55bdd4c to
275397f
Compare
This was referenced Mar 16, 2026
e9b01f1 to
e462f68
Compare
abc3e7c to
135ffbb
Compare
df722d9 to
5b095d3
Compare
135ffbb to
b420700
Compare
xmartinez
approved these changes
Mar 26, 2026
5b095d3 to
0b04f55
Compare
0b04f55 to
41dc43e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Upgrade to meta-memcache-socket 0.2 and migrate MemcacheSocket implementation
This pull request upgrades the
meta-memcache-socketdependency from version 0.1.7 to 0.2 and migrates the codebase to use the external MemcacheSocket implementation.Changes Made
meta-memcache-socketfrom>= 0.1.7, < 0.2to>= 0.2, < 0.3in pyproject.tomlmeta-memcache-socketpackage, removing ~250 lines of codeValue,Success,Miss,NotStored,Conflict) and server version constants from the external packageresult.valuedirectly instead of callingconn.get_value(), as the external implementation populates the value field automatically, reducing the number of calls into rust code.Performance
Technical Details
The external MemcacheSocket implementation now handles value parsing internally, populating the
valuefield ofValueresponses directly. This eliminates the need for the separateget_value()call and simplifies the response handling logic.Test fixtures have been consolidated to provide consistent mocking across the test suite, with
mock_memcache_socketandmock_raw_socketfixtures replacing ad-hoc socket mocking.