Replace command building with direct socket method calls#81
Merged
bisho merged 1 commit intoMar 26, 2026
Merged
Conversation
This was referenced Mar 13, 2026
Member
Author
cdacfbd to
b947f0b
Compare
55bdd4c to
275397f
Compare
This was referenced Mar 16, 2026
b947f0b to
dee32d0
Compare
e9b01f1 to
e462f68
Compare
dee32d0 to
96943d7
Compare
e462f68 to
df722d9
Compare
96943d7 to
e04597e
Compare
df722d9 to
5b095d3
Compare
e04597e to
03324e8
Compare
xmartinez
approved these changes
Mar 26, 2026
03324e8 to
314d081
Compare
5b095d3 to
0b04f55
Compare
314d081 to
7ba0963
Compare
7ba0963 to
fe73264
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Refactor DefaultExecutor to use MemcacheSocket meta_* methods directly
This PR refactors the
DefaultExecutorclass to use the new blockingmeta_*methods fromMemcacheSocketinstead of manually building commands and handling send/receive operations separately.Changes Made
_build_cmd()method and updatedexec_on_pool()to use_conn_exec_cmd()which callsconn.meta_get(),conn.meta_set(), etc. directly_process_response()method to handle deserialization and error handling consistently_conn_send_cmd()to useconn.send_meta_*()methods and simplified_conn_recv_response()to reuse the common response processing logicWireSocketfixture that captures actual bytes sent over the socket, replacing mock-based assertions with real wire protocol verificationBenefits
The changes maintain full backward compatibility while making the codebase more robust and easier to maintain.
Performance