Skip to content

Use promiseExit in OAuth source UI#593

Closed
RhysSullivan wants to merge 1 commit intocodex/effect-lint-baselinefrom
codex/effect-lint-react-oauth-ui
Closed

Use promiseExit in OAuth source UI#593
RhysSullivan wants to merge 1 commit intocodex/effect-lint-baselinefrom
codex/effect-lint-react-oauth-ui

Conversation

@RhysSullivan
Copy link
Copy Markdown
Owner

Summary

  • switch OAuth source UI mutations to promiseExit
  • preserve failed mutation paths as stable UI errors instead of reading unknown error messages
  • keep source placeholder cleanup explicit around mutation exits

Verification

  • bunx oxlint -c .oxlintrc.jsonc packages/plugins/mcp/src/react/AddMcpSource.tsx packages/plugins/mcp/src/react/EditMcpSource.tsx packages/react/src/plugins/oauth-sign-in.tsx --deny-warnings
  • git diff --check
  • bun run typecheck (packages/react)
  • bun run typecheck (packages/plugins/mcp)

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 6, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud f78d51d May 06 2026, 03:02 AM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 6, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing f78d51d Commit Preview URL

Branch Preview URL
May 06 2026, 03:02 AM

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 6, 2026

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@593

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@593

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@593

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@593

@executor-js/storage-core

npm i https://pkg.pr.new/@executor-js/storage-core@593

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@593

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@593

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@593

@executor-js/plugin-google-discovery

npm i https://pkg.pr.new/@executor-js/plugin-google-discovery@593

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@593

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@593

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@593

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@593

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@593

executor

npm i https://pkg.pr.new/executor@593

commit: f78d51d

@RhysSullivan
Copy link
Copy Markdown
Owner Author

Closing as superseded by focused PRs: #643 covers AddMcpSource, #645 covers oauth-sign-in, and #682 preserves the unique EditMcpSource cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant