fix: enable scrolling in welcome view custom API options#11801
Open
roomote[bot] wants to merge 1 commit intomainfrom
Open
fix: enable scrolling in welcome view custom API options#11801roomote[bot] wants to merge 1 commit intomainfrom
roomote[bot] wants to merge 1 commit intomainfrom
Conversation
Fixes #11800 - When selecting a 3rd-party provider like OpenAI Compatible in the welcome view, the API options container used overflow-clip which prevented scrolling when content exceeded the max-height. Changing to overflow-y-auto enables vertical scrolling while preserving the expand/collapse animation.
roomote
bot
requested review from
cte,
daniel-lxs,
hannesrudolph,
jr and
mrubens
as code owners
dosubot
bot
added
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #11800
Description
This PR attempts to address Issue #11800, based on feedback from @SkarnerV.
The welcome view's API options container used
overflow-clipwhich prevented scrolling when content exceeded themax-h-[600px]constraint. When selecting providers like "OpenAI Compatible" that render many fields, the extra content was clipped and unreachable.The fix changes
overflow-cliptooverflow-y-autoinWelcomeViewProvider.tsx(line 380), which enables vertical scrolling within the container while preserving the expand/collapse animation that relies onmax-heighttransitioning from0to600px.Feedback and guidance are welcome.
Test Procedure
Existing tests pass:
cd webview-ui && npx vitest run src/components/welcome/__tests__/WelcomeViewProvider.spec.tsx(13 passed, 2 skipped)Pre-Submission Checklist
Screenshots / Videos
N/A - CSS-only change, visual verification needed in the extension.
Documentation Updates
No documentation updates are required.
Additional Notes
Single-line change:
overflow-clip->overflow-y-autoinwebview-ui/src/components/welcome/WelcomeViewProvider.tsx.Interactively review PR in Roo Code Cloud