chore: bump version to 2.0.4 and update SURF_API_VERSION format#299
chore: bump version to 2.0.4 and update SURF_API_VERSION format#299ammodev merged 1 commit intoversion/26.1from
Conversation
There was a problem hiding this comment.
Pull request overview
Bumps the Gradle plugin version and adjusts how the plugin resolves Surf API artifacts/versions, including updating the test-server plugin download to the Paper server artifact.
Changes:
- Bump
surf-api-gradle-pluginversion from2.0.3to2.0.4. - Update
RunServer.withSurfApiBukkit()to download thesurf-api-paper-serverrelease artifact. - Change generated
Constants.SURF_API_VERSIONvalue used for dependency coordinates.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| surf-api-gradle-plugin/src/main/kotlin/dev/slne/surf/api/gradle/util/run-server-extensions.kt | Switches GitHub download artifact name to surf-api-paper-server-...-all.jar for runServer setup. |
| surf-api-gradle-plugin/build.gradle.kts | Bumps plugin version and modifies generated constants, including SURF_API_VERSION. |
| | const val JAVA_VERSION = $javaVersion | ||
| | const val MINECRAFT_VERSION = "$mcVersion" | ||
| | const val SURF_API_VERSION = "$mcVersion+" | ||
| | const val SURF_API_VERSION = "+" | ||
| | |
There was a problem hiding this comment.
SURF_API_VERSION is now set to just "+", which makes SurfApiPlatform resolve dependencies like dev.slne.surf.api:surf-api-core:+. This is non-reproducible and can pull an incompatible major/Minecraft-targeted version unexpectedly. Consider generating a constrained dynamic version (e.g., include the target Minecraft/version prefix), or derive an explicit version from a dedicated Gradle property (or the plugin/root version) instead of plain +.
| github( | ||
| "SLNE-Development", | ||
| "surf-api", | ||
| "v${Constants.SURF_API_FULL_VERSION}", | ||
| "surf-api-bukkit-server-${Constants.SURF_API_FULL_VERSION}-all.jar" | ||
| "surf-api-paper-server-${Constants.SURF_API_FULL_VERSION}-all.jar" | ||
| ) |
There was a problem hiding this comment.
This helper is still named/documented as adding the “Bukkit server”, but it now downloads the surf-api-paper-server-... artifact. To avoid confusion (and potential misconfiguration by consumers), either rename the extension (keeping a deprecated alias for backward compatibility) and/or update the KDoc to reflect Paper.
No description provided.