Skip to content

chore: bump version to 2.0.4 and update SURF_API_VERSION format #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ammodev merged 1 commit into from
Apr 5, 2026
+3 −3
Merged

chore: bump version to 2.0.4 and update SURF_API_VERSION format #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions surf-api-gradle-plugin/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ plugins {

group = groupId
version = buildString {
append("2.0.3")
append("2.0.4")
if (snapshot) append("-SNAPSHOT")
}

Expand Down Expand Up @@ -138,7 +138,7 @@ val generateConstants by tasks.registering {
|
| const val JAVA_VERSION = $javaVersion
| const val MINECRAFT_VERSION = "$mcVersion"
| const val SURF_API_VERSION = "$mcVersion+"
| const val SURF_API_VERSION = "+"
|
Comment on lines 139 to 142
Copy link

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SURF_API_VERSION is now set to just "+", which makes SurfApiPlatform resolve dependencies like dev.slne.surf.api:surf-api-core:+. This is non-reproducible and can pull an incompatible major/Minecraft-targeted version unexpectedly. Consider generating a constrained dynamic version (e.g., include the target Minecraft/version prefix), or derive an explicit version from a dedicated Gradle property (or the plugin/root version) instead of plain +.

Copilot uses AI. Check for mistakes.
| const val COMMAND_API_VERSION = "${libs.versions.commandapi.get()}"
| const val PLACEHOLDER_API_VERSION = "${libs.versions.placeholder.api.get()}"
Expand Down
2 changes: 1 addition & 1 deletion ...-api-gradle-plugin/src/main/kotlin/dev/slne/surf/api/gradle/util/run-server-extensions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ fun RunServer.withSurfApiBukkit() {
"SLNE-Development",
"surf-api",
"v${Constants.SURF_API_FULL_VERSION}",
"surf-api-bukkit-server-${Constants.SURF_API_FULL_VERSION}-all.jar"
"surf-api-paper-server-${Constants.SURF_API_FULL_VERSION}-all.jar"
)
}
}