-
Notifications
You must be signed in to change notification settings - Fork 225
Add cart_line_properties to tax_calculation deploy config #6843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The CLI was silently dropping cart_line_properties during deploy because the field was missing from both the zod schema and the deployConfig output. The server-side already fully supports cart_line_properties as a first-class field with its own validation and feature flag gating. This adds a CartLinePropertySchema and includes cart_line_properties in the schema and deploy config so TOML entries are parsed and sent to the server. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Coverage report
Test suite run success3721 tests passing in 1441 suites. Report generated by 🧪jest coverage report action from 295f070 |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
xuyuanx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm except for one open question

Why are these changes introduced?
This PR adds support for cart line properties in tax calculation extensions. As part of the Tax Platform API enhancements project, tax partners can now include cart line properties in their calculation requests.
This update ensures that these properties are correctly persisted and not dropped from the
.tomlconfiguration during CLI deployments. We use the properties in this toml to determine what properties we send.WHAT is this pull request doing?
cart_line_propertiesfield to the tax calculation extension schema.CartLinePropertySchemato enforce valid key-value structures.How to test your changes?
extension.tomlfile: