Skip to content

Add cart_line_properties to tax_calculation deploy config #6843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZDahir wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −0
Open

Add cart_line_properties to tax_calculation deploy config #6843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83104ab
Add cart_line_properties to tax_calculation deploy config
ZDahir Feb 10, 2026
295f070
Add cart_line_properties to tax calculation loader test
ZDahir Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/app/src/cli/models/app/loader.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1736,6 +1736,9 @@ redirect_urls = [ "https://example.com/api/auth" ]
namespace = "my-namespace"
key = "my-key"

[[cart_line_properties]]
key = "_use_vip_token"

# extra fields not included in the schema should be ignored
[[invalid_field]]
namespace = "my-namespace"
Expand Down Expand Up @@ -1766,6 +1769,11 @@ redirect_urls = [ "https://example.com/api/auth" ]
key: 'my-key',
},
],
cart_line_properties: [
{
key: '_use_vip_token',
},
],
input: {
metafield_identifiers: {
namespace: 'taxy-tax',
Expand Down
6 changes: 6 additions & 0 deletions packages/app/src/cli/models/extensions/specifications/tax_calculation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ import {createExtensionSpecification} from '../specification.js'
import {BaseSchema, MetafieldSchema} from '../schemas.js'
import {zod} from '@shopify/cli-kit/node/schema'

const CartLinePropertySchema = zod.object({
key: zod.string(),
})

const TaxCalculationsSchema = BaseSchema.extend({
production_api_base_url: zod.string(),
benchmark_api_base_url: zod.string().optional(),
Expand All @@ -17,6 +21,7 @@ const TaxCalculationsSchema = BaseSchema.extend({
})
.optional(),
metafields: zod.array(MetafieldSchema).optional(),
cart_line_properties: zod.array(CartLinePropertySchema).optional(),
})

const spec = createExtensionSpecification({
Expand All @@ -30,6 +35,7 @@ const spec = createExtensionSpecification({
benchmark_api_base_url: config.benchmark_api_base_url,
calculate_taxes_api_endpoint: config.calculate_taxes_api_endpoint,
metafields: config.metafields,
cart_line_properties: config.cart_line_properties,
api_version: config.api_version,
metafield_identifiers: config.input?.metafield_identifiers,
}
Expand Down
Loading