Conversation
amomchilov
requested review from
dersam,
juniper-shopify,
mathiusj and
nfgrep
as code owners
amomchilov
force-pushed
the
Alex/use-type_toolkit
branch
from
ad01be5 to
84fcbda
Compare
amomchilov
force-pushed
the
Alex/use-type_toolkit
branch
from
84fcbda to
e7f2c20
Compare
| # | ||
| # source://type_toolkit//lib/type_toolkit/ext/nil_assertions.rb#10 | ||
| module Kernel | ||
| # : -> self |
There was a problem hiding this comment.
@Morriar Any idea why this isn't get picked up and emitted as a sig?
It looks right in the gem code: https://github.com/Shopify/type_toolkit/blob/v0.0.5/lib/type_toolkit/ext/nil_assertions.rb
There was a problem hiding this comment.
There's no space in the gme source. Tapioca is added it in an attempt to format the docstring, but it's not recognizing it as an RBS sig
There was a problem hiding this comment.
The space should have been fixed since Shopify/tapioca#2364. What Tapioca version are we using?
There was a problem hiding this comment.
Ahhh I knew this looked familiar, but I couldn't find it.
Roast is using 0.16.11, but we need 0.17.8 for that bugfix. Bumping.
There was a problem hiding this comment.
Bumped in a new PR stacked under this on, #839
amomchilov
force-pushed
the
Alex/use-type_toolkit
branch
from
e7f2c20 to
1aa9cbd
Compare
amomchilov
changed the base branch from
graphite-base/838
to
Alex/upgrade-sorbet
amomchilov
force-pushed
the
Alex/use-type_toolkit
branch
from
1aa9cbd to
7171dbc
Compare
dersam
force-pushed
the
Alex/use-type_toolkit
branch
from
7171dbc to
45595f5
Compare
3 participants
Roast doesn't need its own copy anymore :)