Conversation
amomchilov
commented
Mar 5, 2026
|
|
||
| private | ||
|
|
||
| #: (singleton(Roast::Cog)) -> Array(Symbol, singleton(Cog)) |
Contributor
Author
There was a problem hiding this comment.
This was never valid syntax. Fixed.
| # ### See Also | ||
| # - `chat` - Pure LLM interaction without local system access | ||
| # | ||
| #: (?Symbol?) {(Roast::Cogs::Agent::Input, untyped, Integer) [self: Roast::CogInputContext] -> (String | void)} -> void |
Contributor
Author
There was a problem hiding this comment.
String | void isn't a valid type.
Either you return something (like a String), or you don't void. Returning either something or nothing, means you always return something.
String | nil (i.e. String?) would be the closest to the intent here, but that would require users to always have their block return either a String or literal nil. This would break many existing uers, including the examples in the doc comment.
So then we'd want String | top , but that's just equivalent to top. It would be nice to keep the union as a form of user documentation, but Sorbet forces you to reduce it to top.
dersam
approved these changes
Mar 5, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To import RBIs of gems that use RBS signatures, we need Tapioca
0.17.8or higher. This PR bumps Tapioca, but also Sorbet. Due to some incompatibilities, the two have to be bumped together.Needed for #839.
Easier to review commit-by-commit. The second commit is all just RBI updates.