Skip to content

Upgrade Sorbet and Tapioca #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dersam merged 2 commits into from
Mar 5, 2026
Merged

Upgrade Sorbet and Tapioca #839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a9b806
Upgrade Sorbet and Tapioca
amomchilov Mar 4, 2026
222a3e7
`bin/tapioca gem --all`
amomchilov Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ group :development, :test do
gem "rubocop-shopify", require: false
gem "rubocop-sorbet", require: false
gem "simplecov", require: false
gem "sorbet", "~> 0.5.12414", require: false
gem "sorbet", ">= 0.6.12698", require: false
gem "sqlite3", require: false
gem "tapioca", "~> 0.16.11", require: false
gem "tapioca", ">= 0.17.8", require: false
gem "vcr", require: false
gem "webmock", require: false
end
38 changes: 22 additions & 16 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,12 +126,15 @@ GEM
rb-fsevent (0.11.2)
rb-inotify (0.11.1)
ffi (~> 1.0)
rbi (0.3.6)
rbi (0.3.9)
prism (~> 1.0)
rbs (>= 3.4.4)
rbs (3.9.4)
rbs (4.0.0.dev.5)
logger
prism (>= 1.3.0)
tsort
regexp_parser (2.10.0)
require-hooks (0.2.3)
rexml (3.4.2)
rubocop (1.77.0)
json (~> 2.3)
Expand Down Expand Up @@ -171,35 +174,38 @@ GEM
simplecov_json_formatter (~> 0.1)
simplecov-html (0.13.2)
simplecov_json_formatter (0.1.4)
sorbet (0.5.12414)
sorbet-static (= 0.5.12414)
sorbet-runtime (0.5.12414)
sorbet-static (0.5.12414-universal-darwin)
sorbet-static (0.5.12414-x86_64-linux)
sorbet-static-and-runtime (0.5.12414)
sorbet (= 0.5.12414)
sorbet-runtime (= 0.5.12414)
spoom (1.6.3)
sorbet (0.6.12984)
sorbet-static (= 0.6.12984)
sorbet-runtime (0.6.12984)
sorbet-static (0.6.12984-universal-darwin)
sorbet-static (0.6.12984-x86_64-linux)
sorbet-static-and-runtime (0.6.12984)
sorbet (= 0.6.12984)
sorbet-runtime (= 0.6.12984)
spoom (1.7.11)
erubi (>= 1.10.0)
prism (>= 0.28.0)
rbi (>= 0.3.3)
rbs (>= 4.0.0.dev.4)
rexml (>= 3.2.6)
sorbet-static-and-runtime (>= 0.5.10187)
thor (>= 0.19.2)
sqlite3 (2.9.0-arm64-darwin)
sqlite3 (2.9.0-x86_64-linux-gnu)
tapioca (0.16.11)
tapioca (0.17.10)
benchmark
bundler (>= 2.2.25)
netrc (>= 0.11.0)
parallel (>= 1.21.0)
rbi (~> 0.2)
rbi (>= 0.3.7)
require-hooks (>= 0.2.2)
sorbet-static-and-runtime (>= 0.5.11087)
spoom (>= 1.2.0)
spoom (>= 1.7.9)
thor (>= 1.2.0)
yard-sorbet
thor (1.4.0)
traces (0.18.2)
tsort (0.2.0)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
unicode-display_width (3.1.4)
Expand Down Expand Up @@ -233,9 +239,9 @@ DEPENDENCIES
rubocop-shopify
rubocop-sorbet
simplecov
sorbet (~> 0.5.12414)
sorbet (>= 0.6.12698)
sqlite3
tapioca (~> 0.16.11)
tapioca (>= 0.17.8)
vcr
webmock

Expand Down
6 changes: 3 additions & 3 deletions lib/roast/cog/registry.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,13 @@ def initialize
#
#: (singleton(Roast::Cog)) -> void
def use(cog_class)
reg = create_registration(cog_class)
cogs[reg.first] = reg.second
name, klass = create_registration(cog_class)
cogs[name] = klass
end

private

#: (singleton(Roast::Cog)) -> Array(Symbol, singleton(Cog))
Copy link
Contributor Author

@amomchilov amomchilov Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was never valid syntax. Fixed.

#: (singleton(Roast::Cog)) -> [Symbol, singleton(Cog)]
def create_registration(cog_class)
cog_class_name = cog_class.name
raise CouldNotDeriveCogNameError if cog_class_name.nil?
Expand Down
Loading