fix(core): Add missing virtual keyword to ParticleSystemManagerDummy overrides

[bobtista]

• Relates to refactor: Add override/final keywords to virtual functions with VC6 compatibility #2101

Add missing virtual keyword to 6 override functions in ParticleSystemManagerDummy. This class was added after the GameEngine override PRs (#2391/#2392) merged, so it was missed in the sweep.

[greptile-apps]

Greptile Summary

This PR adds the missing virtual keyword to 6 override methods in ParticleSystemManagerDummy, bringing it into style consistency with the virtual ... override pattern used throughout the base class ParticleSystemManager. The class was introduced after the original GameEngine override sweep (PRs #2391/#2392) and was overlooked.

• Applies virtual to getOnScreenParticleCount(), doParticles(), and queueParticleRender() in the public section.
• Applies virtual to crc(), xfer(), and loadPostProcess() in the protected section.
• While virtual is technically redundant when override is already present (C++ guarantees virtuality for overrides), this change matches the established codebase style and makes the intent explicit at a glance.
• No functional behaviour change — purely a style/consistency fix.

Confidence Score: 5/5

• This PR is safe to merge — it is a no-op style consistency fix with no functional impact.
• The change is minimal and mechanically correct: adding virtual alongside override is redundant in C++ but matches the established virtual ... override pattern used in ParticleSystemManager and throughout the codebase. No logic is altered, all custom rules are satisfied, and there are no new issues introduced.
• No files require special attention.

Important Files Changed

Filename	Overview
Core/GameEngine/Include/GameClient/ParticleSys.h	Adds virtual keyword to 6 override methods in ParticleSystemManagerDummy, matching the virtual ... override style used throughout the base class ParticleSystemManager.

Class Diagram

%%{init: {'theme': 'neutral'}}%%
classDiagram
    class SubsystemInterface {
        +virtual init()
        +virtual reset()
        +virtual update()
    }

    class Snapshot {
        #virtual crc(Xfer*)
        #virtual xfer(Xfer*)
        #virtual loadPostProcess()
    }

    class ParticleSystemManager {
        +virtual getOnScreenParticleCount() int
        +virtual doParticles(RenderInfoClass&)
        +virtual queueParticleRender()
        #virtual crc(Xfer*) override
        #virtual xfer(Xfer*) override
        #virtual loadPostProcess() override
    }

    class ParticleSystemManagerDummy {
        +virtual getOnScreenParticleCount() int override
        +virtual doParticles(RenderInfoClass&) override
        +virtual queueParticleRender() override
        #virtual crc(Xfer*) override
        #virtual xfer(Xfer*) override
        #virtual loadPostProcess() override
    }

    SubsystemInterface <|-- ParticleSystemManager
    Snapshot <|-- ParticleSystemManager
    ParticleSystemManager <|-- ParticleSystemManagerDummy

Loading

_{Reviews (1): Last reviewed commit: "fix: Add missing virtual keyword to Part..." | Re-trigger Greptile}

[xezon]

Perhaps this can be added to one of the other 3 pending pulls instead of adding just another one for such a trivial edit?

[bobtista]

Folded into #2394 as suggested by xezon.