Conversation
…ling in patch processing
Member
|
Even if this is mostly some code organization and checks i will hold this one off until current master is tested properly as knowing how cursed this shitty format alone is... i dont wanna leave any chances |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves robustness and compatibility in the
patch_krdir.rsmodule by adding stricter validation, handling optional fields, and refactoring code to reduce duplication. The changes focus on error handling, compression mode support, and streamlining decompression logic.Validation and error handling improvements:
impl KrPatchDir.parse_hd19andparse_hd13. [1] [2]read_block_maybe_zstdfunction.Compatibility and parsing enhancements:
parse_hd19_head.apply_patch.Code refactoring:
read_block_maybe_zstdhelper function to unify decompression logic and reduce code duplication in block reading for covers and headers. [1] [2] [3]…ling in patch processing