Fix XPT writing for LABELV8/9 headers #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorcha
changed the title
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates writing for OBSV8 and LABELV8/9 headers in SAS XPORT files (see tidyverse/haven#784).
LABELV8/9 headers are only used when writing variable labels longer than 40 characters and includes the number of variables with long labels in the header, but this number is left aligned instead of right aligned.
The OBSV8 headers were working fine but I cleaned up the function a little while I was at it since the label and obs headers are now using their own functions for V8 files instead of sharing a header writing function due to the differing alignment.
Have tested with SAS and all looks to be working fine.