Skip to content

Fix XPT writing for LABELV8/9 headers #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evanmiller merged 1 commit into from
Nov 23, 2025
Merged

Fix XPT writing for LABELV8/9 headers #349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions src/sas/readstat_xport_write.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,21 @@ static readstat_error_t xport_write_record(readstat_writer_t *writer, const char
return retval;
}

static readstat_error_t xport_write_header_record_v8(readstat_writer_t *writer,
static readstat_error_t xport_write_header_record_obsv8(readstat_writer_t *writer,
int row_count) {
char record[RECORD_LEN+1];
snprintf(record, sizeof(record),
"HEADER RECORD*******OBSV8 HEADER RECORD!!!!!!!" "%15d",
row_count);
return xport_write_record(writer, record);
}

static readstat_error_t xport_write_header_record_labelv8(readstat_writer_t *writer,
xport_header_record_t *xrecord) {
char record[RECORD_LEN+1];
snprintf(record, sizeof(record),
"HEADER RECORD*******%-8sHEADER RECORD!!!!!!!" "%15d" "%15d",
xrecord->name, xrecord->num1, xrecord->num2);
"HEADER RECORD*******%-8sHEADER RECORD!!!!!!!" "%-5d",
xrecord->name, xrecord->num1);
return xport_write_record(writer, record);
}

Expand Down Expand Up @@ -167,7 +176,7 @@ static readstat_error_t xport_write_variables(readstat_writer_t *writer) {
if (any_has_long_format) {
strcpy(header.name, "LABELV9");
}
retval = xport_write_header_record_v8(writer, &header);
retval = xport_write_header_record_labelv8(writer, &header);
if (retval != READSTAT_OK)
goto cleanup;

Expand Down Expand Up @@ -357,11 +366,7 @@ static readstat_error_t xport_write_namestr_header_record(readstat_writer_t *wri

static readstat_error_t xport_write_obs_header_record(readstat_writer_t *writer) {
if (writer->version == 8) {
xport_header_record_t xrecord = {
.name = "OBSV8",
.num1 = writer->row_count
};
return xport_write_header_record_v8(writer, &xrecord);
return xport_write_header_record_obsv8(writer, writer->row_count);
}
xport_header_record_t xrecord = {
.name = "OBS"
Expand Down
Loading