dqt: replace $.ajax with lorisFetch by Montekkundan · Pull Request #10335 · aces/Loris

Montekkundan · 2026-02-05T18:43:57Z

Summary

Replace $.ajax calls with lorisFetch in dqt.

Why

This removes jQuery AJAX usage in this module for issue #4213.

Scope

Only AJAX replacement in this module. No unrelated jQuery refactors.

Dependency

Depends on PR #10333.

Verification

git grep '\$\.ajax' is clean for touched files.

Montekkundan · 2026-02-10T17:09:47Z

Follow-up pushed to align with #9999 Client guidance for JSON/data requests.

Updated

Added module client: modules/dqt/jsx/DQTClient.js
Migrated JSON/data calls in modules/dqt/jsx/react.app.js to client methods.

Notes

Stream-reader setup/session loaders remain on lorisFetch intentionally because they process streamed responses (response.body.getReader()), not standard JSON request flows.

HenriRabalais · 2026-02-11T15:51:53Z

modules/dqt/jsx/react.app.js

+        const data = await this.client.getJSON(
+          loris.BaseURL + '/AjaxHelper.php?Module=dqt&script=' + script + '&' +
+            new URLSearchParams({
+              category: rule.instrument,
+              field: rule.field,
+              value: rule.value,
+            })
+        );


the Client is designed to avoid manually contructed the URL like this, the Query class should be used in this case.

HenriRabalais · 2026-02-11T15:52:31Z

modules/dqt/jsx/DQTClient.js

+  getJSON(url) {
+    return this.fetchJSON(new URL(url, window.location.origin), {
+      method: 'GET',
+      headers: {'Accept': 'application/json'},
+    });
+  }


the get function in the Client class is designed to do this.

HenriRabalais · 2026-02-11T15:53:52Z

modules/dqt/jsx/react.app.js

+    const response = await lorisFetch(
      `${loris.BaseURL}/dqt/dqt_setup/?format=json`,
-      {credentials: 'same-origin', method: 'GET'}
+      {method: 'GET'}


the Client get function with a Query param for the format and a setSubEndpoint should be able to handle this

HenriRabalais · 2026-02-11T15:54:53Z

modules/dqt/jsx/react.app.js

+    const response = await lorisFetch(
      `${loris.BaseURL}/dqt/sessions/?format=json`,
-      {credentials: 'same-origin', method: 'GET'}
+      {method: 'GET'}


the Client get function with a Query param for the format and a setSubEndpoint should be able to handle this

HenriRabalais · 2026-02-11T16:06:45Z

modules/dqt/jsx/DQTClient.js

+    });
+    if (!response.ok) {
+      const error = new Error('request_failed');
+      error.status = response.status;
+      error.response = response;
+      throw error;
+    }
+    return response.text();
+  }
+}


I don't think we should use fetch or fetchJSON directly here. The Client class is an abstraction layer designed to handle URL building and error reporting for you. By calling fetch directly, you're losing the /dqt base path and our custom error-handling system.

If you need to fetch raw text or send URL-encoded data, I would do that using lorisFetch.

HenriRabalais · 2026-02-11T16:08:26Z

modules/dqt/jsx/react.app.js

+          curRequest = this.client.getJSON(
+            loris.BaseURL
              + '/AjaxHelper.php?Module=dqt&script=GetDoc.php&DocID='
-              + encodeURIComponent(this.state.queryIDs[key][i])), {
-              data: {
-                DocID: this.state.queryIDs[key][i],
-              },
-              dataType: 'json',
-            }).then((value) => {
-            let queries = this.state.savedQueries;
-            queries[value._id] = value;
-            this.setState({savedQueries: queries});
-          });
+              + encodeURIComponent(this.state.queryIDs[key][i])
+          )


the Client get function with a Query param for the format and a setSubEndpoint should be able to handle this

HenriRabalais · 2026-02-11T16:08:56Z

modules/dqt/jsx/react.app.js

+    this.client.getJSON(
+      loris.BaseURL + '/dqt/ajax/datadictionary.php?' +
+        new URLSearchParams({keys: JSON.stringify(fieldsList)})
+    )
+      .then((data) => {


the Client get function with a Query param for the format and a setSubEndpoint should be able to handle this

HenriRabalais

Across the refactors I notice a pattern here of bypassing the established Http.Client abstraction. By using native fetch, manual URL string concatenation, and custom error handling inside the Client extension classes, we lose the benefits of our centralized system for predictable URL building, standardized logging, error and response handling.

Our design goal is to keep the Client strictly for modern JSON/REST interactions. As I outlined in my original comment on your lorisFetch PR, I think legacy PHP helpers that require URL-encoding or return raw text should use your lorisFetch.

HenriRabalais

Client implementation looks good!

feat(dqt): replace $.ajax with lorisFetch

8ea224f

github-actions bot added Language: Javascript PR or issue that update Javascript code Module: dqt PR or issue related to (old) dqt module labels Feb 5, 2026

Montekkundan mentioned this pull request Feb 5, 2026

Remove $.ajax usage, add lorisFetch wrapper, and drop ajax-dependent vendor libs #10327

Closed

driusan added the State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed label Feb 5, 2026

HenriRabalais self-assigned this Feb 10, 2026

refactor(dqt): use Client-based module client for JSON data requests

bcfd1ae

HenriRabalais reviewed Feb 11, 2026

View reviewed changes

HenriRabalais suggested changes Feb 11, 2026

View reviewed changes

refactor(dqt): align Client usage with aces#9999 architecture

260ea90

HenriRabalais reviewed Feb 13, 2026

View reviewed changes

HenriRabalais removed their assignment Feb 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

dqt: replace $.ajax with lorisFetch#10335

dqt: replace $.ajax with lorisFetch#10335
Montekkundan wants to merge 3 commits intoaces:mainfrom
Montekkundan:montek/issue-4213-dqt-fetch

Montekkundan commented Feb 5, 2026

Uh oh!

Montekkundan commented Feb 10, 2026

Uh oh!

HenriRabalais Feb 11, 2026

Uh oh!

HenriRabalais Feb 11, 2026

Uh oh!

HenriRabalais Feb 11, 2026 •

edited

Loading

Uh oh!

HenriRabalais Feb 11, 2026

Uh oh!

HenriRabalais Feb 11, 2026

Uh oh!

HenriRabalais Feb 11, 2026

Uh oh!

HenriRabalais Feb 11, 2026

Uh oh!

HenriRabalais left a comment •

edited

Loading

Uh oh!

HenriRabalais left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

Montekkundan commented Feb 5, 2026

Summary

Why

Scope

Dependency

Verification

Uh oh!

Montekkundan commented Feb 10, 2026

Updated

Notes

Uh oh!

HenriRabalais Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

HenriRabalais Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

HenriRabalais Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HenriRabalais Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

HenriRabalais Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

HenriRabalais Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

HenriRabalais Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

HenriRabalais left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HenriRabalais left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HenriRabalais Feb 11, 2026 •

edited

Loading

HenriRabalais left a comment •

edited

Loading