Strict mode #126
Closed
Strict mode #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
shazron
requested changes
Jan 23, 2025
| }), | ||
| strict: Flags.boolean({ | ||
| description: 'Run in strict mode, this will block non-web actions from being run directly', | ||
| defaullt: false |
| } | ||
|
|
||
| if (invoker && !sequence) { | ||
| if (invoker && !sequence && !actionConfig.strictMode) { |
Member
There was a problem hiding this comment.
Where is the serveNonWebAction code? That needs to be resurrected here (it was deleted in the previous PR) and enabled by --strict. If not the e2e tests will fail since they expect 401s for non-web actions being called.
Member
Author
|
stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We shortcut some logic to make it quick and easy for developers to test/debug their non-web actions. This pr adds a --strict flag to closer mimic the behavior of Adobe Runtime.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: