Skip to content

Strict mode #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
purplecabbage wants to merge 5 commits into from
Closed

Strict mode #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f7c51f9
pass strict flag through to runDev
purplecabbage Jan 8, 2025
819d81e
reject non-web action in strict mode
purplecabbage Jan 9, 2025
1c1ce18
Merge branch 'main' into StrictMode
purplecabbage Jan 15, 2025
52241d0
Merge branch 'main' into StrictMode
purplecabbage Jan 29, 2025
918dbe5
Merge branch 'main' into StrictMode
shazron Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/commands/app/dev/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ class Dev extends BaseCommand {
const runOptions = {
skipActions: false,
skipServe: false,
strictMode: flags.strict,
parcel: {
logLevel: flags.verbose ? 'verbose' : 'warn',
// always set to false on localhost to get debugging and hot reloading
Expand Down Expand Up @@ -305,6 +306,10 @@ Dev.flags = {
default: false,
char: 'o'
}),
strict: Flags.boolean({
description: 'Run in strict mode, this will block non-web actions from being run directly',
defaullt: false
Copy link
Member

@shazron shazron Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo default

}),
extension: Flags.string({
description: 'Run only a specific extension, this flag can only be specified once',
char: 'e',
Expand Down
5 changes: 3 additions & 2 deletions src/lib/run-dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ async function runDev (runOptions, config, _inprocHookRunner) {
const hasBackend = devConfig.app.hasBackend
const httpsSettings = runOptions?.parcel?.https

actionConfig.strictMode = runOptions.strictMode === true

serveLogger.debug('hasBackend', hasBackend)
serveLogger.debug('hasFrontend', hasFrontend)
serveLogger.debug('httpsSettings', JSON.stringify(httpsSettings, null, 2))
Expand Down Expand Up @@ -508,8 +510,7 @@ async function serveWebAction (req, res, actionConfig, distFolder, actionLoader
distFolder,
contextActionLoader: actionLoader
}

if (invoker && !sequence) {
if (invoker && !sequence && !actionConfig.strictMode) {
Copy link
Member

@shazron shazron Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the serveNonWebAction code? That needs to be resurrected here (it was deleted in the previous PR) and enabled by --strict. If not the e2e tests will fail since they expect 401s for non-web actions being called.

if (!isWebAction(contextItem)) {
actionLogger.warn('serving non-web action : this call will fail without credentials when deployed.')
}
Expand Down
Loading