Conversation
…se build to checksum artifacts
There was a problem hiding this comment.
Pull request overview
This PR addresses two release/packaging issues in Apache Atlas: (1) fixing release checksum files to avoid including the target/ path prefix in the generated checksum output, and (2) ensuring import-kafka.sh has required runtime JARs available by copying missing dependencies into the Kafka bridge distribution layout.
Changes:
- Generate MD5/SHA checksum outputs from within
${release-dir}so checksum lines reference only the artifact filename (nottarget/<file>). - Copy
commons-lang:commons-langandorg.apache.hadoop:hadoop-commoninto the Kafka bridge hook dependency directory during thedistprofile build. - Add a module-level
commons-lang.versionproperty to pin the copied artifact version.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
release-build.xml |
Adjusts checksum generation commands to run in ${release-dir} so checksum output doesn’t include directory prefixes. |
addons/kafka-bridge/pom.xml |
Ensures required JARs are copied into the Kafka bridge hook dependency directory for import-kafka.sh. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <exec executable="gpg" output="${release-dir}/${build-release-tar-file}.md5" dir="${release-dir}"> | ||
| <arg value="--print-md" /> | ||
| <arg value="MD5" /> | ||
| <arg value="${release-dir}/${build-release-tar-file}" /> | ||
| <arg value="${build-release-tar-file}" /> | ||
| </exec> |
There was a problem hiding this comment.
The MD5/SHA* checksum generation now runs in ${release-dir} so the output filenames won’t be prefixed with target/, but the legacy .mds checksum generation still runs gpg --print-mds against ${release-dir}/${build-release-tar-file} (release-build.xml:67-70). That will continue to emit target/<tarball>: in the .mds file, so the ATLAS-5263 formatting issue is only partially resolved. Consider applying the same dir="${release-dir}" + ${build-release-tar-file} argument change to the .mds exec (or removing .mds generation if it’s no longer used).
What changes were proposed in this pull request?
ATLAS-5268: import-kafka.sh is failing due to missing jars commons-lang and hadoop-common.
ATLAS-5263: Checksum is getting created by including dir path as
target/apache-atlas-2.5.0-sources.tar.gz: but expected is apache-atlas-2.5.0-sources.tar.gz:
How was this patch tested?
Tested with Docker build