Skip to content

ATLAS-5268: ATLAS-5263: Issues with import-kafka.sh and enhance release build to checksum artifacts #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rkundam merged 1 commit into from
Apr 7, 2026
+17 −6
Merged

ATLAS-5268: ATLAS-5263: Issues with import-kafka.sh and enhance release build to checksum artifacts #590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions addons/kafka-bridge/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
<properties>
<checkstyle.failOnViolation>true</checkstyle.failOnViolation>
<checkstyle.skip>false</checkstyle.skip>
<commons-lang.version>2.6</commons-lang.version>
</properties>

<dependencies>
Expand Down Expand Up @@ -423,6 +424,11 @@
<artifactId>commons-logging</artifactId>
<version>${commons-logging.version}</version>
</artifactItem>
<artifactItem>
<groupId>commons-lang</groupId>
<artifactId>commons-lang</artifactId>
<version>${commons-lang.version}</version>
</artifactItem>
<artifactItem>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
Expand Down Expand Up @@ -498,6 +504,11 @@
<artifactId>json-simple</artifactId>
<version>${json-simple.version}</version>
</artifactItem>
<artifactItem>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-common</artifactId>
<version>${hadoop.version}</version>
</artifactItem>
</artifactItems>
</configuration>
</execution>
Expand Down
12 changes: 6 additions & 6 deletions release-build.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,22 +69,22 @@
<arg value="${release-dir}/${build-release-tar-file}" />
</exec>

<exec executable="gpg" output="${release-dir}/${build-release-tar-file}.md5">
<exec executable="gpg" output="${release-dir}/${build-release-tar-file}.md5" dir="${release-dir}">
<arg value="--print-md" />
<arg value="MD5" />
<arg value="${release-dir}/${build-release-tar-file}" />
<arg value="${build-release-tar-file}" />
</exec>
Comment on lines +72 to 76
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MD5/SHA* checksum generation now runs in ${release-dir} so the output filenames won’t be prefixed with target/, but the legacy .mds checksum generation still runs gpg --print-mds against ${release-dir}/${build-release-tar-file} (release-build.xml:67-70). That will continue to emit target/<tarball>: in the .mds file, so the ATLAS-5263 formatting issue is only partially resolved. Consider applying the same dir="${release-dir}" + ${build-release-tar-file} argument change to the .mds exec (or removing .mds generation if it’s no longer used).

Copilot uses AI. Check for mistakes.

<exec executable="gpg" output="${release-dir}/${build-release-tar-file}.sha256">
<exec executable="gpg" output="${release-dir}/${build-release-tar-file}.sha256" dir="${release-dir}">
<arg value="--print-md" />
<arg value="SHA256" />
<arg value="${release-dir}/${build-release-tar-file}" />
<arg value="${build-release-tar-file}" />
</exec>

<exec executable="gpg" output="${release-dir}/${build-release-tar-file}.sha512">
<exec executable="gpg" output="${release-dir}/${build-release-tar-file}.sha512" dir="${release-dir}">
<arg value="--print-md" />
<arg value="SHA512" />
<arg value="${release-dir}/${build-release-tar-file}" />
<arg value="${build-release-tar-file}" />
</exec>
</target>
</project>
Loading