Prevent multi-select dropdown menu from floating on scrolling through the form#11237
Prevent multi-select dropdown menu from floating on scrolling through the form#11237DaanHoogland merged 2 commits into4.19from
Conversation
|
@rosi-shapeblue Can you please review if this fixes the issue. Thanks. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.19 #11237 +/- ##
============================================
+ Coverage 4.28% 15.18% +10.89%
- Complexity 0 11365 +11365
============================================
Files 372 5415 +5043
Lines 29746 475901 +446155
Branches 5230 58097 +52867
============================================
+ Hits 1274 72252 +70978
- Misses 28327 395564 +367237
- Partials 145 8085 +7940
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c342c92 to
9c6c57f
Compare
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@Pearl1594 , I could not fine domain on the add compute offering modal, but then so I think there are more to do |
Thanks Daan. I've addressed it at other places. |
|
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
|
looks great @Pearl1594 and I think we can merge as is, but I also found some select fields in the add backup offering that do not move with the parent when scrolling. |
|
@Pearl1594 I think this will be needed across UI if we want consistent behaviour. Maybe we need to create a new custom select component which enforces this behaviour. For starters, if we want to change it in just the offering forms, that is fine too. |
|
I agree @shwstppr , merging this is a good start but enforcing behaviour with a systemwide component makes sense. |
|
I agree as well. I think that's a better way to move ahead. Thanks. |





Description
This PR fixes #11217
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Screencast.from.2025-07-17.12.04.06.PM.webm
How did you try to break this feature and the system with this change?