Skip to content

CLOUDSTACK-10238: Fix for metalink support on SSVM agents#2411

Closed
nvazquez wants to merge 1 commit intoapache:4.11from
shapeblue:fr16fixmetalink
Closed

CLOUDSTACK-10238: Fix for metalink support on SSVM agents#2411
nvazquez wants to merge 1 commit intoapache:4.11from
shapeblue:fr16fixmetalink

Conversation

@nvazquez
Copy link
Contributor

@nvazquez nvazquez commented Jan 18, 2018

Fix for #2379. In that PR, aria2 dependency is added to system vm template to support metalink downloads on SSVM agents. This feature fixes metalink downloader issue and extends metalink support for OVA and ISO formats.

@nvazquez nvazquez added this to the 4.11.1 milestone Jan 18, 2018
@borisstoyanov
Copy link
Contributor

borisstoyanov commented Jan 19, 2018

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jan 19, 2018

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jan 19, 2018

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1662

@borisstoyanov
Copy link
Contributor

borisstoyanov commented Jan 19, 2018

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Jan 19, 2018

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Jan 19, 2018

Trillian test result (tid-2173)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31320 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2411-t2173-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_usage.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 64 look OK, 3 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_04_extract_template Failure 128.35 test_templates.py
ContextSuite context=TestISOUsage>:setup Error 0.00 test_usage.py
test_06_download_detached_volume Failure 136.58 test_volumes.py

borisstoyanov
borisstoyanov approved these changes Jan 22, 2018
View reviewed changes
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I've re-run the failing bits on a new env and they all pass.

test_09_copy_delete_template (tests.smoke.test_templates.TestCopyDeleteTemplate) ... SKIP: Skipping test due to there are less than two zones.
Test create public & private template ... === TestName: test_01_create_template | Status : SUCCESS ===
ok
Test when createTemplate is used to create templates having the same name all of them get ... === TestName: test_CreateTemplateWithDuplicateName | Status : SUCCESS ===
ok
test_02_1_create_template_with_checksum_sha1_negative (tests.smoke.test_templates.TestCreateTemplateWithChecksum) ... === TestName: test_02_1_create_template_with_checksum_sha1_negative | Status : SUCCESS ===
ok
test_02_create_template_with_checksum_sha1 (tests.smoke.test_templates.TestCreateTemplateWithChecksum) ... === TestName: test_02_create_template_with_checksum_sha1 | Status : SUCCESS ===
ok
test_03_1_create_template_with_checksum_sha256_negative (tests.smoke.test_templates.TestCreateTemplateWithChecksum) ... === TestName: test_03_1_create_template_with_checksum_sha256_negative | Status : SUCCESS ===
ok
test_03_create_template_with_checksum_sha256 (tests.smoke.test_templates.TestCreateTemplateWithChecksum) ... === TestName: test_03_create_template_with_checksum_sha256 | Status : SUCCESS ===
ok
test_04_1_create_template_with_checksum_md5_negative (tests.smoke.test_templates.TestCreateTemplateWithChecksum) ... === TestName: test_04_1_create_template_with_checksum_md5_negative | Status : SUCCESS ===
ok
test_04_create_template_with_checksum_md5 (tests.smoke.test_templates.TestCreateTemplateWithChecksum) ... === TestName: test_04_create_template_with_checksum_md5 | Status : SUCCESS ===
ok
test_05_create_template_with_no_checksum (tests.smoke.test_templates.TestCreateTemplateWithChecksum) ... === TestName: test_05_create_template_with_no_checksum | Status : SUCCESS ===
ok
Register a template using Direct Download flag ... === TestName: test_01_register_template_direct_download_flag | Status : SUCCESS ===
ok
Deploy a VM from a Direct Download registered template ... === TestName: test_02_deploy_vm_from_direct_download_template | Status : SUCCESS ===
ok
Deploy a VM from a Direct Download registered template with wrong checksum ... === TestName: test_03_deploy_vm_wrong_checksum | Status : SUCCESS ===
ok
Test Edit template ... === TestName: test_02_edit_template | Status : SUCCESS ===
ok
Test delete template ... === TestName: test_03_delete_template | Status : SUCCESS ===
ok
Test for extract template ... === TestName: test_04_extract_template | Status : SUCCESS ===
ok
Update & Test for template permissions ... === TestName: test_05_template_permissions | Status : SUCCESS ===
ok
Test for copy template from one zone to another ... SKIP: Not enough zones available to perform copy template
Test only public templates are visible to normal user ... === TestName: test_07_list_public_templates | Status : SUCCESS ===
ok
Test System templates are not visible to normal user ... === TestName: test_08_list_system_templates | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 20 tests in 1431.564s

OK (SKIP=2)

[root@trl-1182-k-cs411-bstoyanov-marvin ~]# cat /marvin//MarvinLogs/test_usage_LFOGPQ/results.txt
Test Create/Delete a ISO and verify its usage is generated correctly ... === TestName: test_01_ISO_usage | Status : SUCCESS ===
ok
Test Create/Delete a LB rule and verify correct usage is recorded ... === TestName: test_01_lb_usage | Status : SUCCESS ===
ok
Test Create/Delete a PF rule and verify correct usage is recorded ... === TestName: test_01_nat_usage | Status : SUCCESS ===
ok
Test Assign new IP and verify usage calculation ... === TestName: test_01_public_ip_usage | Status : SUCCESS ===
ok
Test Create/Delete a manual snap shot and verify ... === TestName: test_01_snapshot_usage | Status : SUCCESS ===
ok
Test Upload/ delete a template and verify correct usage is generated ... === TestName: test_01_template_usage | Status : SUCCESS ===
ok
Test Create/Destroy VM and verify usage calculation ... === TestName: test_01_vm_usage | Status : SUCCESS ===
ok
Test Create/delete a volume and verify correct usage is recorded ... === TestName: test_01_volume_usage | Status : SUCCESS ===
ok
Test Create/Delete a VPN and verify correct usage is recorded ... === TestName: test_01_vpn_usage | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 9 tests in 1223.220s

OK

[root@trl-1182-k-cs411-bstoyanov-marvin ~]# cat /marvin//MarvinLogs/test_volumes_0K875D/results.txt
Test Volume creation for all Disk Offerings (incl. custom) ... === TestName: test_01_create_volume | Status : SUCCESS ===
ok
Attach a created Volume to a Running VM ... === TestName: test_02_attach_volume | Status : SUCCESS ===
ok
Download a Volume attached to a VM ... === TestName: test_03_download_attached_volume | Status : SUCCESS ===
ok
Delete a Volume attached to a VM ... === TestName: test_04_delete_attached_volume | Status : SUCCESS ===
ok
Detach a Volume attached to a VM ... === TestName: test_05_detach_volume | Status : SUCCESS ===
ok
Download a Volume unattached to an VM ... === TestName: test_06_download_detached_volume | Status : SUCCESS ===
ok
Test resize (negative) non-existent volume ... === TestName: test_07_resize_fail | Status : SUCCESS ===
ok
Test resize a volume ... === TestName: test_08_resize_volume | Status : SUCCESS ===
ok
Delete a Volume unattached to an VM ... === TestName: test_09_delete_detached_volume | Status : SUCCESS ===
ok
test_10_list_volumes (tests.smoke.test_volumes.TestVolumes) ... === TestName: test_10_list_volumes | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 10 tests in 2263.823s

OK

@nvazquez
Copy link
Contributor Author

nvazquez commented Jan 25, 2018

Thanks for the manual verification @borisstoyanov! Waiting for confirmation on the aria2 usage

@yadvr
Copy link
Member

yadvr commented Feb 10, 2018

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Feb 10, 2018

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Feb 10, 2018

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1699

@yadvr
Copy link
Member

yadvr commented Feb 10, 2018

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Feb 10, 2018

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Feb 11, 2018

Trillian test result (tid-2246)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 22664 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2411-t2246-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Smoke tests completed. 67 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

borisstoyanov
borisstoyanov approved these changes Feb 12, 2018
View reviewed changes
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests LGTM

@nvazquez
Copy link
Contributor Author

nvazquez commented Feb 14, 2018

Thanks @borisstoyanov! @DaanHoogland would you please review?

borisstoyanov
borisstoyanov reviewed Feb 15, 2018
View reviewed changes
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nvazquez isn't this still using aria2?

@nvazquez
Copy link
Contributor Author

nvazquez commented Feb 15, 2018

It is @borisstoyanov, it is then replaced for both Direct Download and SSVM on #2447

@DaanHoogland DaanHoogland mentioned this pull request Feb 15, 2018
Merged
@nvazquez
Copy link
Contributor Author

nvazquez commented Feb 19, 2018

Closing as it is included on 2408

@nvazquez nvazquez closed this Feb 19, 2018
@nvazquez nvazquez deleted the fr16fixmetalink branch April 6, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@borisstoyanov borisstoyanov borisstoyanov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.11.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nvazquez @borisstoyanov @blueorangutan @yadvr