fix: correct assetion logic#122
Merged
Merged
Conversation
notfilippo
approved these changes
May 11, 2026
Member
notfilippo
left a comment
notfilippo
left a comment
There was a problem hiding this comment.
Makes sense to me! Thanks for catching
Open
tisonkun
approved these changes
May 11, 2026
Member
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
LGTM. This should be guarded with a unit test, which we can add later.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For exceptions stored in the auxiliary map, the corresponding register should be the max possible value (
AUX_TOKEN).I believe we have to assert the opposite of what we do in that case, that is that the value of the slot is
AUX_TOKEN.