chore(deps): bump hwlocality and passterm, fix non-tty password read#3084
Merged
chore(deps): bump hwlocality and passterm, fix non-tty password read#3084
Conversation
passterm 2.0.6 broke the non-tty password fallback path. prompt_password_stdin now calls tcsetattr on STDIN_FILENO to disable echo, which fails with ENOTTY when stdin is piped. Replaced with direct stdin read_line, stripping only line terminators to match passterm's strip_newline behavior and preserve trailing whitespace in passwords. - hwlocality: 1.0.0-alpha.11 -> 1.0.0-alpha.12 - passterm: =2.0.1 -> 2.0.6 (exact pin removed)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3084 +/- ##
============================================
- Coverage 70.66% 70.63% -0.04%
Complexity 943 943
============================================
Files 1114 1114
Lines 94778 94780 +2
Branches 71978 71995 +17
============================================
- Hits 66976 66946 -30
- Misses 25332 25340 +8
- Partials 2470 2494 +24
🚀 New features to boost your workflow:
|
spetz
approved these changes
Apr 7, 2026
mmodzelewski
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
passterm 2.0.6 broke the non-tty password fallback path.
prompt_password_stdin now calls tcsetattr on STDIN_FILENO
to disable echo, which fails with ENOTTY when stdin is
piped. Replaced with direct stdin read_line, stripping
only line terminators to match passterm's strip_newline
behavior and preserve trailing whitespace in passwords.