KAFKA-19655: Align the behavior of num.partitions and default.replication.factor for topic creation#21550
Merged
showuon merged 4 commits intoapache:trunkfrom Mar 3, 2026
Merged
Conversation
…itions and default.replication.factor from the controller properties
brandboat
changed the title
Member
Author
|
gentle ping @chia7712, @FrankYang0529, @lucasbru, @showuon, could you please take a look when you're available? |
showuon
reviewed
Mar 3, 2026
Member
showuon
left a comment
showuon
left a comment
There was a problem hiding this comment.
Thanks for the PR! Overall LGTM! Left some comments.
Comment on lines
-128
to
+134
| props.setProperty(GroupCoordinatorConfig.OFFSETS_TOPIC_REPLICATION_FACTOR_CONFIG, internalTopicPartitions.toString) | ||
| props.setProperty(TransactionLogConfig.TRANSACTIONS_TOPIC_REPLICATION_FACTOR_CONFIG, internalTopicPartitions.toString) | ||
| props.setProperty(ShareCoordinatorConfig.STATE_TOPIC_REPLICATION_FACTOR_CONFIG , internalTopicPartitions.toString) | ||
| props.setProperty(GroupCoordinatorConfig.OFFSETS_TOPIC_REPLICATION_FACTOR_CONFIG, internalTopicReplicationFactor.toString) | ||
| props.setProperty(TransactionLogConfig.TRANSACTIONS_TOPIC_REPLICATION_FACTOR_CONFIG, internalTopicReplicationFactor.toString) | ||
| props.setProperty(ShareCoordinatorConfig.STATE_TOPIC_REPLICATION_FACTOR_CONFIG , internalTopicReplicationFactor.toString) | ||
|
|
||
| props.setProperty(GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_CONFIG, internalTopicReplicationFactor.toString) | ||
| props.setProperty(TransactionLogConfig.TRANSACTIONS_TOPIC_PARTITIONS_CONFIG, internalTopicReplicationFactor.toString) | ||
| props.setProperty(ShareCoordinatorConfig.STATE_TOPIC_NUM_PARTITIONS_CONFIG, internalTopicReplicationFactor.toString) | ||
| props.setProperty(GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_CONFIG, internalTopicPartitions.toString) | ||
| props.setProperty(TransactionLogConfig.TRANSACTIONS_TOPIC_PARTITIONS_CONFIG, internalTopicPartitions.toString) | ||
| props.setProperty(ShareCoordinatorConfig.STATE_TOPIC_NUM_PARTITIONS_CONFIG, internalTopicPartitions.toString) |
Member
There was a problem hiding this comment.
Nice catch! Why could we pass the tests with the wrong setting?
Member
Author
There was a problem hiding this comment.
Since they both point to the same value, so everything stay in peace 😆
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| @ClusterTestDefaults(types = {Type.KRAFT}, brokers = 2) | ||
| public class AutoTopicCreationTest { |
Member
There was a problem hiding this comment.
Could we add a test case that both broker and controller nodes have no num.partitions and default.replication.factor set, and verify the default value 1 should takes place?
Member
Author
There was a problem hiding this comment.
Sure, let me add one, thanks!
chia7712
reviewed
Mar 4, 2026
| // warn if create.topic.policy.class.name or alter.config.policy.class.name is defined in the broker role | ||
| warnIfConfigDefinedInWrongRole(ProcessRole.ControllerRole, ServerLogConfigs.CREATE_TOPIC_POLICY_CLASS_NAME_CONFIG) | ||
| warnIfConfigDefinedInWrongRole(ProcessRole.ControllerRole, ServerLogConfigs.ALTER_CONFIG_POLICY_CLASS_NAME_CONFIG) | ||
| if (originals.containsKey(ServerLogConfigs.NUM_PARTITIONS_CONFIG)) { |
Member
There was a problem hiding this comment.
Could you refactor warnIfConfigDefinedInWrongRole to ensure consistent warning messages?
nicktelford
pushed a commit
to nicktelford/kafka
that referenced
this pull request
Mar 6, 2026
…tion.factor for topic creation (apache#21550) Currently, 'num.partitions' and 'default.replication.factor' are applied inconsistently. Topic auto-creation relies on Broker configs, while Streams and AdminClient rely on Controller configs. This leads to confusing behavior where a Broker and Controller might have diverging defaults. This commit implements the 4.x transition phase: - Updated DefaultAutoTopicCreationManager to check if these configs are explicitly set in 'broker.properties'. - If NOT explicitly set, the Broker now sends 'NO_NUM_PARTITIONS' and 'NO_REPLICATION_FACTOR' (-1) in the CreateTopicsRequest, allowing the Controller's configuration to take precedence. - Added deprecation warnings in KafkaConfig when these properties are defined in a Broker role, notifying users to migrate them to the Controller role before 5.0. - Updated documentation to clarify the precedence logic between Broker and Controller nodes. Reviewers: Luke Chen <showuon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, 'num.partitions' and 'default.replication.factor' are applied
inconsistently. Topic auto-creation relies on Broker configs, while
Streams and AdminClient rely on Controller configs. This leads to
confusing behavior where a Broker and Controller might have diverging
defaults.
This commit implements the 4.x transition phase:
explicitly set in 'broker.properties'.
'NO_REPLICATION_FACTOR' (-1) in the CreateTopicsRequest, allowing
the Controller's configuration to take precedence.
defined in a Broker role, notifying users to migrate them to the
Controller role before 5.0.
Broker and Controller nodes.
Reviewers: Luke Chen showuon@gmail.com