KAFKA-19655: Align the behavior of num.partitions and default.replication.factor for topic creation #21550
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.kafka.clients.admin; | ||
|
|
||
| import org.apache.kafka.clients.producer.Producer; | ||
| import org.apache.kafka.clients.producer.ProducerRecord; | ||
| import org.apache.kafka.common.test.ClusterInstance; | ||
| import org.apache.kafka.common.test.api.ClusterConfigProperty; | ||
| import org.apache.kafka.common.test.api.ClusterTest; | ||
| import org.apache.kafka.common.test.api.ClusterTestDefaults; | ||
| import org.apache.kafka.common.test.api.Type; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| @ClusterTestDefaults(types = {Type.KRAFT}, brokers = 2) | ||
| public class AutoTopicCreationTest { | ||
|
|
||
| @ClusterTest( | ||
| serverProperties = { | ||
| @ClusterConfigProperty(id = 0, key = "num.partitions", value = "5"), | ||
| @ClusterConfigProperty(id = 0, key = "default.replication.factor", value = "2"), | ||
| @ClusterConfigProperty(id = 1, key = "num.partitions", value = "5"), | ||
| @ClusterConfigProperty(id = 1, key = "default.replication.factor", value = "2"), | ||
| } | ||
| ) | ||
| public void testAutoCreateTopicWithExplicitBrokerConfig(ClusterInstance cluster) throws Exception { | ||
| String topic = "explicit-broker-topic"; | ||
| triggerAutoCreateTopic(cluster, topic); | ||
| try (Admin admin = cluster.admin()) { | ||
| TopicDescription desc = admin.describeTopics(List.of(topic)).allTopicNames().get().get(topic); | ||
| assertEquals(5, desc.partitions().size(), | ||
| "num.partitions explicitly set on broker should be used"); | ||
| assertEquals(2, desc.partitions().get(0).replicas().size(), | ||
| "default.replication.factor explicitly set on broker should be used"); | ||
| } | ||
| } | ||
|
|
||
| @ClusterTest( | ||
| serverProperties = { | ||
| @ClusterConfigProperty(id = 3000, key = "num.partitions", value = "5"), | ||
| @ClusterConfigProperty(id = 3000, key = "default.replication.factor", value = "2"), | ||
| } | ||
| ) | ||
| public void testAutoCreateTopicWithImplicitBrokerConfig(ClusterInstance cluster) throws Exception { | ||
| String topic = "implicit-broker-topic"; | ||
| triggerAutoCreateTopic(cluster, topic); | ||
| try (Admin admin = cluster.admin()) { | ||
| TopicDescription desc = admin.describeTopics(List.of(topic)).allTopicNames().get().get(topic); | ||
| assertEquals(5, desc.partitions().size(), | ||
| "Controller num.partitions should be used when broker does not explicitly set it"); | ||
| assertEquals(2, desc.partitions().get(0).replicas().size(), | ||
| "Controller default.replication.factor should be used when broker does not explicitly set it"); | ||
| } | ||
| } | ||
|
|
||
| @ClusterTest( | ||
| serverProperties = { | ||
| @ClusterConfigProperty(id = 0, key = "num.partitions", value = "5"), | ||
| @ClusterConfigProperty(id = 1, key = "num.partitions", value = "5"), | ||
| @ClusterConfigProperty(id = 3000, key = "default.replication.factor", value = "2"), | ||
| } | ||
| ) | ||
| public void testAutoCreateTopicWithMixedConfig(ClusterInstance cluster) throws Exception { | ||
| String topic = "mixed-config-topic"; | ||
| triggerAutoCreateTopic(cluster, topic); | ||
| try (Admin admin = cluster.admin()) { | ||
| TopicDescription desc = admin.describeTopics(List.of(topic)).allTopicNames().get().get(topic); | ||
| assertEquals(5, desc.partitions().size(), | ||
| "num.partitions explicitly set on broker should be used"); | ||
| assertEquals(2, desc.partitions().get(0).replicas().size(), | ||
| "Controller default.replication.factor should be used when broker does not set it"); | ||
| } | ||
| } | ||
|
|
||
| @ClusterTest | ||
| public void testAutoCreateTopicWithDefaultConfig(ClusterInstance cluster) throws Exception { | ||
| String topic = "default-config-topic"; | ||
| triggerAutoCreateTopic(cluster, topic); | ||
| try (Admin admin = cluster.admin()) { | ||
| TopicDescription desc = admin.describeTopics(List.of(topic)).allTopicNames().get().get(topic); | ||
| assertEquals(1, desc.partitions().size(), | ||
| "Default num.partitions of 1 should be used when neither broker nor controller sets it"); | ||
| assertEquals(1, desc.partitions().get(0).replicas().size(), | ||
| "Default default.replication.factor of 1 should be used when neither broker nor controller sets it"); | ||
| } | ||
| } | ||
|
|
||
| private void triggerAutoCreateTopic(ClusterInstance cluster, String topic) throws Exception { | ||
| // Sends a produce request to a non-existent topic so that auto topic creation is triggered. | ||
| try (Producer<byte[], byte[]> producer = cluster.producer()) { | ||
| ProducerRecord<byte[], byte[]> record = | ||
| new ProducerRecord<>(topic, null, "key".getBytes(), "value".getBytes()); | ||
| producer.send(record).get(); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a test case that both broker and controller nodes have no
num.partitionsanddefault.replication.factorset, and verify the default value 1 should takes place?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, let me add one, thanks!