MINIFICPP-2677 Move GCP tests to modular docker tests #2071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
lordgamez
added
depends-on-another-PR
low-impact
lordgamez
force-pushed
the
MINIFICPP-2689
branch
from
9d59e30 to
0d4a898
Compare
lordgamez
force-pushed
the
MINIFICPP-2677
branch
from
22a74fc to
22d54f3
Compare
szaszm
approved these changes
Dec 9, 2025
Member
szaszm
left a comment
szaszm
left a comment
There was a problem hiding this comment.
Just one small thing, but I'm +1 for the PR after the dependencies are fixed and merged
Comment on lines
+22
to
+23
| if files is not None: | ||
| self.files = files |
Member
There was a problem hiding this comment.
Wouldn't we want to initialize it to an empty dictionary when files is not injected?
Contributor
Author
There was a problem hiding this comment.
Yes, we initialize it to an empty dictionary on line 21.
fgerlits
reviewed
Dec 12, 2025
| def __init__(self, test_context: MinifiTestContext): | ||
| super().__init__("fsouza/fake-gcs-server:1.45.1", f"fake-gcs-server-{test_context.scenario_id}", test_context.network, | ||
| command=f'-scheme http -host fake-gcs-server-{test_context.scenario_id}') | ||
| self.dirs.append(Directory(path="/data/test-bucket", files={"test-file": "preloaded data\n"})) |
Contributor
There was a problem hiding this comment.
this means that ./docker/test/integration/resources/fake-gcs-server-data/test-bucket/test-file can be removed now, right?
lordgamez
force-pushed
the
MINIFICPP-2689
branch
from
0d4a898 to
b825077
Compare
lordgamez
force-pushed
the
MINIFICPP-2677
branch
from
22d54f3 to
fd29a4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2677
Depends on #2068
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.