Merged
Conversation
This commit also removes a cast that is no longer needed after python/mypy#20602
correctmost
force-pushed
the
cm/upgrade-mypy
branch
from
236ce55 to
a6d4536
Compare
correctmost
commented
Apr 1, 2026
| # Setting an empty keymap first, allows the subsequent call to set layout for both console and x11. | ||
| with Boot(self.target) as session: | ||
| os.system('systemd-run --machine=archinstall --pty localectl set-keymap ""') | ||
| os.system('systemd-run --machine=archinstall --pty localectl set-keymap ""') # type: ignore[deprecated, unused-ignore] |
Contributor
Author
There was a problem hiding this comment.
My local version of mypy 1.20.0 (with Python 3.14.3) flags the deprecated ignores as unused, so I added "unused-ignore" for now too:
archinstall/lib/installer.py:2000: error: Unused "type: ignore" comment [unused-ignore]
svartkanin
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
This commit also removes a cast that is no longer needed after python/mypy#20602