Skip to content

Update mypy to 1.20.0 #4352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svartkanin merged 2 commits into from
Apr 1, 2026
+7 −8
Merged

Update mypy to 1.20.0 #4352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b62b243
Update mypy to 1.20.0
correctmost Apr 1, 2026
a6d4536
Ignore os.system deprecation warnings from mypy to fix CI
correctmost Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ repos:
args: [--config=.flake8]
fail_fast: true
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v1.19.1
rev: v1.20.0
hooks:
- id: mypy
args: [
Expand Down
4 changes: 2 additions & 2 deletions archinstall/lib/installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1997,7 +1997,7 @@ def set_keyboard_language(self, language: str) -> bool:
# In accordance with https://github.com/archlinux/archinstall/issues/107#issuecomment-841701968
# Setting an empty keymap first, allows the subsequent call to set layout for both console and x11.
with Boot(self.target) as session:
os.system('systemd-run --machine=archinstall --pty localectl set-keymap ""')
os.system('systemd-run --machine=archinstall --pty localectl set-keymap ""') # type: ignore[deprecated, unused-ignore]
Copy link
Copy Markdown
Contributor Author

@correctmost correctmost Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My local version of mypy 1.20.0 (with Python 3.14.3) flags the deprecated ignores as unused, so I added "unused-ignore" for now too:

archinstall/lib/installer.py:2000: error: Unused "type: ignore" comment  [unused-ignore]


try:
session.SysCommand(['localectl', 'set-keymap', language])
Expand Down Expand Up @@ -2063,7 +2063,7 @@ def _service_state(self, service_name: str) -> str:


def accessibility_tools_in_use() -> bool:
return os.system('systemctl is-active --quiet espeakup.service') == 0
return os.system('systemctl is-active --quiet espeakup.service') == 0 # type: ignore[deprecated, unused-ignore]


def run_custom_user_commands(commands: list[str], installation: Installer) -> None:
Expand Down
1 change: 0 additions & 1 deletion archinstall/lib/menu/list_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ async def _run(self) -> list[ValueT] | None:
raise ValueError('Unhandled return type')

if value in self._base_actions:
value = cast(str, value)
self._data = await self.handle_action(value, None, self._data)
elif value in self._terminate_actions:
break
Expand Down
2 changes: 1 addition & 1 deletion archinstall/scripts/guided.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def perform_installation(
case PostInstallationAction.EXIT:
pass
case PostInstallationAction.REBOOT:
_ = os.system('reboot')
_ = os.system('reboot') # type: ignore[deprecated, unused-ignore]
case PostInstallationAction.CHROOT:
try:
installation.drop_to_shell()
Expand Down
4 changes: 2 additions & 2 deletions archinstall/tui/curses_menu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1312,7 +1312,7 @@ def print(
clear_screen: bool = False,
) -> None:
if clear_screen:
os.system('clear')
os.system('clear') # type: ignore[deprecated, unused-ignore]

if Tui._t is None:
print(text, end=endl)
Expand Down Expand Up @@ -1357,7 +1357,7 @@ def _main_loop[ValueT](self, component: AbstractCurses[ValueT]) -> Result[ValueT
return component.kickoff(self._screen)

def _reset_terminal(self) -> None:
os.system('reset')
os.system('reset') # type: ignore[deprecated, unused-ignore]

def _set_up_colors(self) -> None:
curses.init_pair(STYLE.NORMAL.value, curses.COLOR_WHITE, curses.COLOR_BLACK)
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Source = "https://github.com/archlinux/archinstall"
[project.optional-dependencies]
log = ["systemd_python==235"]
dev = [
"mypy==1.19.1",
"mypy==1.20.0",
"flake8==7.3.0",
"pre-commit==4.5.1",
"ruff==0.15.7",
Expand Down
Loading