fix(infra): use cross-platform compatible checks script#1525
Merged
fix(infra): use cross-platform compatible checks script#1525
Conversation
Replace the pnpm regex pattern with explicit commands chained via &&. The regex pattern with single quotes does not work properly on Windows cmd.exe. Fixes aws#1512
kmcginnes
approved these changes
Feb 19, 2026
Collaborator
|
Thank you for this, @abhu85! This helps a lot since I don't use Windows. I don't love that this solution slows down running checks on non-Windows systems, but I believe it is better to have it work at all than to quibble about 5-10 seconds. Approved! 🚀 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1525 +/- ##
===========================================
+ Coverage 47.81% 64.87% +17.06%
===========================================
Files 382 356 -26
Lines 8525 7949 -576
Branches 3159 2906 -253
===========================================
+ Hits 4076 5157 +1081
+ Misses 3070 2010 -1060
+ Partials 1379 782 -597
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the pnpm regex pattern with explicit commands chained via
&&. The regex pattern with single quotes does not work properly on Windows cmd.exe.Changes
package.jsonfrom"checks": "pnpm run '/^check:.*/'",to"checks": "pnpm run check:lint && pnpm run check:format && pnpm run check:types",Test plan
&&operator is cross-platform compatibleFixes #1512