Skip to content

Comments

fix(infra): use cross-platform compatible checks script#1525

Merged
kmcginnes merged 1 commit intoaws:mainfrom
abhu85:fix/windows-pnpm-checks-1512
Feb 19, 2026
Merged

fix(infra): use cross-platform compatible checks script#1525
kmcginnes merged 1 commit intoaws:mainfrom
abhu85:fix/windows-pnpm-checks-1512

Conversation

@abhu85
Copy link
Contributor

@abhu85 abhu85 commented Feb 18, 2026

Summary

Replace the pnpm regex pattern with explicit commands chained via &&. The regex pattern with single quotes does not work properly on Windows cmd.exe.

Changes

  • Changed line 25 in package.json from "checks": "pnpm run '/^check:.*/'", to "checks": "pnpm run check:lint && pnpm run check:format && pnpm run check:types",

Test plan

  • Code review passed
  • All check scripts verified to exist in package.json
  • && operator is cross-platform compatible

Fixes #1512

Replace the pnpm regex pattern with explicit commands chained via &&. The regex pattern with single quotes does not work properly on Windows cmd.exe.

Fixes aws#1512
@kmcginnes
Copy link
Collaborator

Thank you for this, @abhu85! This helps a lot since I don't use Windows.

I don't love that this solution slows down running checks on non-Windows systems, but I believe it is better to have it work at all than to quibble about 5-10 seconds.

Approved! 🚀

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.87%. Comparing base (c5affc5) to head (f09557b).
⚠️ Report is 66 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1525       +/-   ##
===========================================
+ Coverage   47.81%   64.87%   +17.06%     
===========================================
  Files         382      356       -26     
  Lines        8525     7949      -576     
  Branches     3159     2906      -253     
===========================================
+ Hits         4076     5157     +1081     
+ Misses       3070     2010     -1060     
+ Partials     1379      782      -597     
Flag Coverage Δ
unittests 64.87% <ø> (+17.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kmcginnes kmcginnes merged commit c2bf2df into aws:main Feb 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running pnpm checks on Windows fails

2 participants