Resolve multisampled prepass textures#22849
Open
beicause wants to merge 10 commits intobevyengine:mainfrom
Open
Resolve multisampled prepass textures#22849beicause wants to merge 10 commits intobevyengine:mainfrom
beicause wants to merge 10 commits intobevyengine:mainfrom
Conversation
…d-prepass-textures
f31f505 to
c957c9b
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #22830, fixes #22831
Solution
DepthPrepasstexture is changed toR32Floatwhich is resolved with newResolvePlugininprepass_depth_resolvepass. Bonus: WebGPU doesn't support filterable depth textures, but float32-filterable is generally supported. WebGL2 should also support resolved depth prepass.Multisampled
NormalPrepassandMotionVectorPrepasstextures are transient and are resolved during prepass.Testing
shader_prepassexample can toggle MSAA.DLSS and solari are likely broken due to changed depth prepass texture format.