Skip to content

Use CowArc everywhere for asset labels#22869

Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom
Demiu:main
Feb 9, 2026
Merged

Use CowArc everywhere for asset labels#22869
alice-i-cecile merged 3 commits intobevyengine:mainfrom
Demiu:main

Conversation

@Demiu
Copy link
Copy Markdown
Contributor

@Demiu Demiu commented Feb 8, 2026

Objective

Make the API consistent

Solution

Change the types.

Testing

I ran cargo test --workspace --lib --bins --tests and fixed the warnings and errors. Also cargo check --workspace --examples

On cargo 1.93.0 on windows 10

Copy link
Copy Markdown
Contributor

@andriyDev andriyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and easy! Thanks!

@kfc35 kfc35 added A-Assets Load files from disk to use for things like images, models, and sounds C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Feb 8, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 9, 2026
Merged via the queue into bevyengine:main with commit a6d9870 Feb 9, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Assets Load files from disk to use for things like images, models, and sounds C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants