implement component access for WorldCell#5632
Closed
jakobhellermann wants to merge 2 commits intobevyengine:mainfrom
Closed
implement component access for WorldCell#5632jakobhellermann wants to merge 2 commits intobevyengine:mainfrom
WorldCell#5632jakobhellermann wants to merge 2 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
added
A-ECS
afonsolage
approved these changes
Sep 7, 2022
Contributor
|
WorldCell was removed in #12551, visit the linked PR for the rationale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
WorldCellcan hand out multiple mutable references to resources checked at runtime, but it would be nice if it also worked for componentsSolution
ArchetypeComponentAccessintoEntityComponentAccessWorldBorrow[Mut]to be able to handle accesses of both kinds (resource and component)NOTE: this implementation may not be the most efficient, I'm just using a
HashMapfor the access. We could perhaps implement a more optimized approach inspired by Ralith/hecs#247, but that is something for another PR.Changelog
WorldCell::get_componentandWorldCell::get_component_mut