Switch uv resolution back to default#427
Merged
stefanvanburen merged 2 commits intomainfrom Feb 26, 2026
Merged
Conversation
This switches our version resolution back to the default of "highest", but leaves around our testing of our entire version range in CI. This more closely follows [the recommendation of the uv team][1] for libraries. This should help with resolving some of the GitHub security alerts we get on this repository. [1]: https://docs.astral.sh/uv/concepts/resolution/#resolution-strategy Ref: connectrpc/connect-python#142 Ref: #373 Ref: astral-sh/uv#18178 (comment)
Unclear why we didn't hit this on the previous approach with CI; seems like maybe a `uv` resolution bug?
AdrienVannson
approved these changes
Feb 25, 2026
Contributor
AdrienVannson
left a comment
AdrienVannson
left a comment
There was a problem hiding this comment.
I didn't know about the resolution strategy, this is really nice!
| # We need at least this version, which fixed Python 3.14 compatibility (tp_new metaclass issue). | ||
| # The fix was never backported to the 5.x series. | ||
| # Ref: https://github.com/protocolbuffers/protobuf/pull/20594 | ||
| "protobuf>=6.31.0; python_version >= '3.14'", |
Member
There was a problem hiding this comment.
If it is picking the highest, does this mean if there is a version 7 with potentially breaking changes it picks that up with this config?
Member
Author
There was a problem hiding this comment.
yes, but that's always been the case and we want to avoid an upper limit as a library unless we really know that a v7 will break us. Some references:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches our version resolution back to the default of "highest", but leaves around our testing of our entire version range in CI. This more closely follows the recommendation of the uv team for libraries. This should help with resolving some of the GitHub security alerts we get on this repository.
Ref: connectrpc/connect-python#142
Ref: #373
Ref: astral-sh/uv#18178 (comment)