Skip to content

Switch uv resolution back to default #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefanvanburen merged 2 commits into from
Feb 26, 2026
Merged

Switch uv resolution back to default #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38e4b8f
Switch uv resolution back to default
stefanvanburen Feb 25, 2026
68b0ebc
Add tighter version constraint for protobuf on 3.14
stefanvanburen Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ jobs:
- run: make install
- run: make lint
- run: make format
# When running with matrix.resolution == highest, we expect uv.lock to change, but we don't want that file checked in.
- if: matrix.resolution == 'lowest-direct'
# When running with matrix.resolution == lowest-direct, we expect uv.lock to change, but we don't want that file checked in.
- if: matrix.resolution == 'highest'
run: make checkgenerate
env:
BUF_TOKEN: ${{ secrets.BUF_TOKEN }}
Expand Down
7 changes: 4 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ classifiers = [
]
dynamic = ["version"]
dependencies = [
# We need at least this version, which fixed Python 3.14 compatibility (tp_new metaclass issue).
# The fix was never backported to the 5.x series.
# Ref: https://github.com/protocolbuffers/protobuf/pull/20594
"protobuf>=6.31.0; python_version >= '3.14'",
Copy link
Member

@srikrsna-buf srikrsna-buf Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is picking the highest, does this mean if there is a version 7 with potentially breaking changes it picks that up with this config?

Copy link
Member Author

@stefanvanburen stefanvanburen Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but that's always been the case and we want to avoid an upper limit as a library unless we really know that a v7 will break us. Some references:

"protobuf>=5",
"cel-python>=0.5",
# We need at least this version, which started publishing wheels for Python 3.14.
Expand Down Expand Up @@ -49,9 +53,6 @@ dev = [
"types-protobuf>=5.29.1.20250315",
]

[tool.uv]
resolution = "lowest-direct"

[tool.hatch.version]
source = "vcs"
raw-options = { fallback_version = "0.0.0" }
Expand Down
Loading