Open
Conversation
|
Hi, any updates on this PR? This would be a nice to have for my current project as I am playing around with nested browserViews. |
catdad
reviewed
Feb 14, 2023
| function startWatcher() { | ||
| return new Promise((resolve) => { | ||
| const watcher = watch({ root: cwd, patterns }); | ||
| const parentFolder = cwd.replace("\\Host","") |
Owner
There was a problem hiding this comment.
What is this? This is replacing part of a path? That seems odd and unintuitive.
Author
There was a problem hiding this comment.
my apologies, that was something for my own project and shouldn't have been part of this pull request, all other commits should be valid though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as outlined in the issue,
this fixes the bug of BrowserViews that are nested inside BrowserWindow not reloading