Skip to content

fixed reload issue #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Awendel wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fixed reload issue #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5b33e9
fixed reload issue
Awendel Sep 13, 2022
49aaf9d
changed it to watch parentFolder as root to access sibling changes
Awendel Sep 14, 2022
dce73ed
check if win / webContent destroyed before reloading
Awendel Sep 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/electronmon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,8 @@ module.exports = ({

function startWatcher() {
return new Promise((resolve) => {
const watcher = watch({ root: cwd, patterns });
const parentFolder = cwd.replace("\\Host","")
Copy link
Copy Markdown
Owner

@catdad catdad Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this? This is replacing part of a path? That seems odd and unintuitive.

Copy link
Copy Markdown
Author

@Awendel Awendel Feb 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my apologies, that was something for my own project and shouldn't have been part of this pull request, all other commits should be valid though

const watcher = watch({ root: parentFolder, patterns });
globalWatcher = watcher;

watcher.on('change', ({ path: fullpath }) => {
Expand Down
13 changes: 11 additions & 2 deletions src/hook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,20 @@ function reload() {

if (windows && windows.length) {
for (const win of windows) {
win.webContents.reloadIgnoringCache();
if(win.isDestroyed() == false){
win.webContents.reloadIgnoringCache()

const views = win.getBrowserViews()
views.forEach(function(view){
if(view.webContents.isDestroyed() == false){
view.webContents.reloadIgnoringCache()
}
})
}

}
}
}

required.on('file', ({ type, id }) => {
if (type !== 'file') {
return;
Expand Down