Open
Conversation
This fixes the following error: ``` Uncaught TypeError: tab.combinedGeometry is undefined GcodeGenerationViewModel.js:261:20 ``` It occured when adding a holding tab to the geometry. The issue was caused by refactoring to #private syntax (commit 4a979bf), which made `TabGeometry.combinedGeometry` inaccessible. This commit solves the issue by adding a getter method returning the offset geometry.
mv1005
force-pushed
the
fix-tabs-generation
branch
from
a522794 to
17c81a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following error:
It occured when adding a holding tab to the geometry. The issue was caused by refactoring to #private syntax (commit 4a979bf), which made
TabGeometry.combinedGeometryinaccessible.This commit solves the issue by adding a getter method returning the offset geometry.