Skip to content

Fix gcode generation when using tabs #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdot merged 1 commit into from
Mar 27, 2026
Merged

Fix gcode generation when using tabs #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/GcodeGenerationViewModel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,7 @@ export class GcodeGenerationViewModel extends ViewModel {
if (tab.enabled()) {
// Bloat tab geometry by the cutter radius
const bloat = App.models.Tool.cutterDiameter.toUnits("integer") / 2;
const tg = tab.combinedGeometry.offset(bloat);
tabGeometry = tabGeometry.union(tg);
tabGeometry = tabGeometry.union(tab.getOffsetCombinedGeometry(bloat));
}
}

Expand Down
9 changes: 9 additions & 0 deletions src/TabViewModel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,15 @@ export class TabViewModel extends ViewModel {
this.#combinedGeometry = new CutPaths();
}

/**
* Return combined geometry from this tab offset by the given value.
* Used in final gcode generation.
* @param {number} offset offset applied to tab geometry
*/
getOffsetCombinedGeometry(offset) {
return this.#combinedGeometry.offset(offset);
}

/**
* (Re)generate combinedGeometry from the paths associated with this
* operation (this.#tabPaths)
Expand Down