Conversation
There was a problem hiding this comment.
Pull request overview
Adds/updates Machine CR YAML manifests under machines/ to include spec.defaultConfigurations and introduces an additional Machine definition.
Changes:
- Added new Machine manifest
machines/machin-eee.yaml. - Updated
machines/machin-d.yamlto populatespec.defaultConfigurationsinstead of an empty list.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| machines/machin-eee.yaml | New Machine manifest including connection info and default configurations. |
| machines/machin-d.yaml | Changes defaultConfigurations from empty to a populated list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| apiVersion: trading.spectra.fund/v1beta1 | ||
| kind: Machine | ||
| metadata: | ||
| name: infraserver-aliyun-cc-1002 |
There was a problem hiding this comment.
metadata.name duplicates the same Machine name used in other manifests (e.g., machines/machin-ccc.yaml:4). If these YAMLs are meant to be applied together, this will cause resource collisions/last-write-wins behavior. Please give this Machine a unique metadata.name (and, if applicable, adjust file naming to match) or move it under an examples/templates location that isn’t deployed.
| name: infraserver-aliyun-cc-1002 | |
| name: infraserver-aliyun-cc-1003 |
| spec: | ||
| status: Ready | ||
| connection: | ||
| init: "47.239.53.129:3351" |
There was a problem hiding this comment.
This adds a hard-coded external IP:port in spec.connection.init. If this repo is shared/public or used across environments, committing real addresses can be a security/ops risk and makes promotion harder. Consider using a DNS name, an environment-specific overlay, or a reference to a secret/config mechanism instead of an in-repo literal.
| init: "47.239.53.129:3351" | |
| init: "your-endpoint.example.com:3351" |
CI Labels
/ready