Skip to content

Feature/machine #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Huweicai wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feature/machine #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04e25e4
feat: add default configuration for machin-d
Huweicai Feb 6, 2026
a5a556c
feat: add default configuration for machin-eee
Huweicai Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion machines/machin-d.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,6 @@ spec:
connection:
init: "47.239.53.129:3351"
provider: "xxx"
defaultConfigurations: [ ]
defaultConfigurations:
- name: server
value: key
15 changes: 15 additions & 0 deletions machines/machin-eee.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
apiVersion: trading.spectra.fund/v1beta1
kind: Machine
metadata:
name: infraserver-aliyun-cc-1002
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metadata.name duplicates the same Machine name used in other manifests (e.g., machines/machin-ccc.yaml:4). If these YAMLs are meant to be applied together, this will cause resource collisions/last-write-wins behavior. Please give this Machine a unique metadata.name (and, if applicable, adjust file naming to match) or move it under an examples/templates location that isn’t deployed.

Suggested change
name: infraserver-aliyun-cc-1002
name: infraserver-aliyun-cc-1003

Copilot uses AI. Check for mistakes.
labels:
acquisition-type: purchased
env: dev
spec:
status: Ready
connection:
init: "47.239.53.129:3351"
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds a hard-coded external IP:port in spec.connection.init. If this repo is shared/public or used across environments, committing real addresses can be a security/ops risk and makes promotion harder. Consider using a DNS name, an environment-specific overlay, or a reference to a secret/config mechanism instead of an in-repo literal.

Suggested change
init: "47.239.53.129:3351"
init: "your-endpoint.example.com:3351"

Copilot uses AI. Check for mistakes.
provider: "xxx"
defaultConfigurations:
- name: server
value: key
Loading