Add eslint-plugin-newline-destructuring

[lolgab]

Summary

• Add eslint-plugin-newline-destructuring as a dependency and register it in src/eslintPlugins.ts
• Regenerate docs so newline-destructuring_newline appears in patterns.json and all-patterns
• Add a multiple-test (docs/multiple-tests/newline-destructuring/) that enables the rule via .eslintrc.json and asserts the expected checkstyle output

Test plan

• CI plugins_test passes (multiple-tests including newline-destructuring)
• Docker build succeeds

Made with Cursor

[gemini-code-assist]

Code Review

This pull request adds support for the eslint-plugin-newline-destructuring plugin, including updates to the package dependencies, plugin registration, and documentation. It also introduces new test cases for the newline-destructuring/newline pattern. A regression was identified in docs/patterns.json where a relative path was inadvertently changed to an absolute local path, which needs to be reverted to ensure environment portability.

[gemini-code-assist]

The default value for langDir has been updated to an absolute path from a local machine (/Users/lorenzo/...). This is a regression that will cause the tool to fail in other environments (CI, Docker, etc.) where this path does not exist. It should be reverted to the relative path.

Suggested change

	"default": "/Users/lorenzo/codacy/github/codacy-eslint/node_modules/eslint-plugin-spellcheck/rules/utils/dicts"
	"default": "node_modules/eslint-plugin-spellcheck/rules/utils/dicts"

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 duplication

Metric	Results
Duplication	0

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

_{TIP This summary will be updated as you push new changes.}

[codacy-production]

Pull Request Overview

The integration of eslint-plugin-newline-destructuring is mostly complete, but there are critical omissions in the documentation metadata and test configuration. Although the rule is registered and utilized in tests, the metadata in docs/patterns.json and docs/description/description.json lacks the definition of the 'items' parameter. This will prevent users from configuring the rule via the platform UI. Additionally, the integration test patterns.xml fails to enable the rule module, which likely prevents the test from actually validating the logic. These issues should be resolved before merging to ensure maintainability and correct functionality.

About this PR

• The rule newline-destructuring/newline supports an 'items' configuration parameter (as used in your integration tests). However, this parameter is not defined in the documentation metadata, which will prevent it from being configurable via the platform's user interface.

Test suggestions

• Verify that the plugin is correctly registered in the engine's plugin registry.
• Verify that the newline-destructuring/newline rule is present in the generated documentation files.
• Integration test: the newline-destructuring/newline rule flags a single-line destructuring assignment containing 3 items when 'items' threshold is set to 2.

_{TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback}

[codacy-production]

_{🟡 MEDIUM RISK}

The 'patterns.xml' file defines an exclusion filter but fails to enable the actual pattern being tested. Patterns must be explicitly listed as modules to be active during execution.

Suggested change

	<module name="root">
	<module name="BeforeExecutionExclusionFileFilter">
	<property name="fileNamePattern" value=".*\.json" />
	</module>
	</module>
	<module name="root">
	<module name="BeforeExecutionExclusionFileFilter">
	<property name="fileNamePattern" value=".*\.json" />
	</module>
	<module name="newline-destructuring_newline" />
	</module>

[codacy-production]

_{🟡 MEDIUM RISK}

Suggestion: The pattern metadata is incomplete. It lacks a 'description' field and does not define the 'items' parameter, which is supported by the rule and used in the test suite. Defining these is necessary for proper documentation and UI-based configuration.

Suggested update: Update the metadata to include the 'items' parameter (type integer) and a descriptive text (e.g., 'Enforce newline usage in destructuring assignment').

[codacy-production]

_{⚪ LOW RISK}

Suggestion: The 'items' parameter supported by this rule should be added to the parameters array in the documentation metadata.