Skip to content

Add eslint-plugin-newline-destructuring #4975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lolgab wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add eslint-plugin-newline-destructuring #4975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d08e15b
Add eslint-plugin-newline-destructuring
lolgab May 20, 2026
9f5f214
Fix newline-destructuring multiple-test severity
lolgab May 20, 2026
9922c3d
Fix newline-destructuring multiple-test severity
lolgab May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/description/description.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions docs/multiple-tests/all-patterns-typescript/patterns.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1724,6 +1724,7 @@
<module name="n_hashbang" />
<module name="n_no-hide-core-modules" />
<module name="n_shebang" />
<module name="newline-destructuring_newline" />
<module name="no-only-tests_no-only-tests" />
<module name="no-unsanitized_property" />
<module name="no-unsanitized_method" />
Expand Down
1 change: 1 addition & 0 deletions docs/multiple-tests/all-patterns/patterns.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1724,6 +1724,7 @@
<module name="n_hashbang" />
<module name="n_no-hide-core-modules" />
<module name="n_shebang" />
<module name="newline-destructuring_newline" />
<module name="no-only-tests_no-only-tests" />
<module name="no-unsanitized_property" />
<module name="no-unsanitized_method" />
Expand Down
5 changes: 5 additions & 0 deletions docs/multiple-tests/newline-destructuring/patterns.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<module name="root">
<module name="BeforeExecutionExclusionFileFilter">
<property name="fileNamePattern" value=".*\.json" />
</module>
</module>
Comment on lines +1 to +5
Copy link
Copy Markdown

@codacy-production codacy-production Bot May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

The 'patterns.xml' file defines an exclusion filter but fails to enable the actual pattern being tested. Patterns must be explicitly listed as modules to be active during execution.

Suggested change
<module name="root">
<module name="BeforeExecutionExclusionFileFilter">
<property name="fileNamePattern" value=".*\.json" />
</module>
</module>
<module name="root">
<module name="BeforeExecutionExclusionFileFilter">
<property name="fileNamePattern" value=".*\.json" />
</module>
<module name="newline-destructuring_newline" />
</module>

6 changes: 6 additions & 0 deletions docs/multiple-tests/newline-destructuring/results.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<checkstyle version="4.3">
<file name="newline-destructuring.js">
<error source="newline-destructuring_newline" line="2" message="Object desctructuring lines must be broken into multiple lines if there are more than 2 properties" severity="info" />
</file>
</checkstyle>
9 changes: 9 additions & 0 deletions docs/multiple-tests/newline-destructuring/src/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"parserOptions": {
"ecmaVersion": 2020
},
"plugins": ["newline-destructuring"],
"rules": {
"newline-destructuring/newline": ["error", { "items": 2 }]
}
}
2 changes: 2 additions & 0 deletions docs/multiple-tests/newline-destructuring/src/newline-destructuring.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
const obj = { a: 1, b: 2, c: 3 };
const { a, b, c } = obj;
7 changes: 7 additions & 0 deletions docs/patterns.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@
"eslint-plugin-mocha": "^10.4.3",
"eslint-plugin-monorepo": "^0.3.2",
"eslint-plugin-n": "^17.7.0",
"eslint-plugin-newline-destructuring": "^1.2.2",
"eslint-plugin-no-only-tests": "^3.1.0",
"eslint-plugin-no-unsanitized": "^4.0.2",
"eslint-plugin-nuxt": "^4.0.0",
Expand Down
1 change: 1 addition & 0 deletions src/eslintPlugins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ const packageNames: string[] = [
"eslint-plugin-mocha",
"eslint-plugin-monorepo",
"eslint-plugin-n",
"eslint-plugin-newline-destructuring",
"eslint-plugin-no-only-tests",
"eslint-plugin-no-unsanitized",
"eslint-plugin-nuxt",
Expand Down