🤖 fix: restore codecov upload for integration tests#1418
Closed
ammar-agent wants to merge 1 commit intomainfrom
Closed
🤖 fix: restore codecov upload for integration tests#1418ammar-agent wants to merge 1 commit intomainfrom
ammar-agent wants to merge 1 commit intomainfrom
Conversation
The original condition `steps.test-filter.outputs.filter != ''` referenced a non-existent step ID, so integration test coverage was never uploaded. This was introduced in bf49482. Fix by adding an id to the test step and setting `ran=true` output when tests actually run. The codecov upload is now conditioned on this output, so it only runs when there's coverage data to upload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The integration test codecov upload had a condition that referenced a non-existent step:
There is no step with
id: test-filter, so this condition was always false and integration test coverage was never uploaded to Codecov.Root Cause
This was introduced in bf49482 ("refactor: simplify CI and tests folder structure" #908). The refactor removed or renamed a step but kept the condition that referenced it.
Fix
Removed the broken condition so coverage uploads unconditionally, matching the unit test behavior.
Generated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high