Make "--unshare-user-try" check if /proc is mounted with hidepid #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madaidan
changed the title
--unshare-user-try check if /proc is mounted with hidepid
|
Can one of the admins verify this patch?
|
Collaborator
|
That is a very very rough way of detecting the flags (string compare over entire file). There is some mountinfo parsing in bind-mount.c, i think using that for this would make more sense. |
Author
|
It is very rough but I don't know how else to detect the flags. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for #198
It checks if /proc/mounts contains anything related to
hidepid.I'm very new to C so sorry if there's anything wrong. It worked fine when testing.